Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix docs details for app deployment docs #4516

Closed
wants to merge 2 commits into from
Closed

Fix docs details for app deployment docs #4516

wants to merge 2 commits into from

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Dec 16, 2020

Some more fixes in app deployment docs

@kulmann kulmann requested a review from jnweiger December 16, 2020 15:38
@update-docs
Copy link

update-docs bot commented Dec 16, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann requested a review from micbar December 17, 2020 06:37
{{< hint info >}}
Please note that the `server` url needs to have a trailing slash.
{{< /hint >}}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed anymore, thanks to \rtrim

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That only applies to the web.baseUrl. config.json still needs the trailing slash for the server url. On the other hand, it makes more sense to enforce it when loading the server url. Will make a separate PR.

@kulmann
Copy link
Member Author

kulmann commented Dec 17, 2020

Screenshot 2020-12-17 at 12 17 24

@micbar this happens when you provide a server url in the config.json without a trailing slash. My local oc10 testing instance was hosted at http://host.docker.internal/px1 and it needs to be configured as http://host.docker.internal/px1/ in the config.json. Otherwise this happens.

@micbar
Copy link
Contributor

micbar commented Dec 17, 2020

ah, config.json
Sorry, i thought it was config.php

@kulmann
Copy link
Member Author

kulmann commented Dec 17, 2020

@micbar #4536 fixes it. Will adapt this PR accordingly.

@pascalwengerter
Copy link
Contributor

@kulmann definitely not pressing, but this needs a quick rebase and should be good to merge :)

@kulmann
Copy link
Member Author

kulmann commented Jun 25, 2021

Has been solved in other PRs in the meantime. Closing here.

@kulmann kulmann closed this Jun 25, 2021
@pascalwengerter pascalwengerter deleted the docs-fixes branch July 7, 2021 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants