-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix docs details for app deployment docs #4516
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
docs/deployments/oc10-app.md
Outdated
{{< hint info >}} | ||
Please note that the `server` url needs to have a trailing slash. | ||
{{< /hint >}} | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not needed anymore, thanks to \rtrim
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That only applies to the web.baseUrl
. config.json still needs the trailing slash for the server
url. On the other hand, it makes more sense to enforce it when loading the server url. Will make a separate PR.
@micbar this happens when you provide a |
ah, config.json |
@kulmann definitely not pressing, but this needs a quick rebase and should be good to merge :) |
Has been solved in other PRs in the meantime. Closing here. |
Some more fixes in app deployment docs