fix ocis-1043 #4444
Merged
fix ocis-1043 #4444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
approved these changes
Dec 9, 2020
show loading screen while waiting for all required data from backend check for route path instead of name in ADD_NAV_ITEM fix session persist and add only what is required
fschade
force-pushed
the
bugfix-ocis-1043
branch
from
a45f37e to
2cee264
Compare
@LukasHirt, yes its more costy to do it one by one (but not much it's a low level api). The problem if we do the result would for n be [99,2,3] and o is still [1, 2, 3] but if we do we will mutate the original object in o objects in arrays get refferenced and not deep copied. |
kulmann
requested changes
Dec 10, 2020
src/Phoenix.vue
Outdated
| }" | ||
| uk-height-viewport | ||
| > | ||
| <oc-spinner size="xxxlarge" :aria-label="$gettext('Loading')" class="uk-position-center" /> |
There was a problem hiding this comment.
From my personal feeling the spinner is too big. I would choose xlarge size and border sizes in the css class 10px.
| @@ -32,7 +32,9 @@ const mutations = { | |||
| ADD_NAV_ITEM(state, { extension, navItem }) { | |||
| const dynamicNavItems = { ...state.dynamicNavItems } | |||
| dynamicNavItems[extension] = dynamicNavItems[extension] || [] | |||
| const index = dynamicNavItems[extension].findIndex(item => item.name === navItem.name) | |||
| const index = dynamicNavItems[extension].findIndex( | |||
| item => item.route.path === navItem.route.path | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
partially fixes: owncloud/ocis#1043
fixes: owncloud/ocis#884