Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Left menu elements picks browser's language instead of the oC account settings #884

Closed
davitol opened this issue Nov 18, 2020 · 2 comments · Fixed by owncloud/web#4444
Assignees
Labels

Comments

@davitol
Copy link
Contributor

davitol commented Nov 18, 2020

Tested using oCIS 1.0.0.-RC5

Left menu elements picks browser's language instead of the oC account settings

Screenshot 2020-11-18 at 11 27 00

Screenshot 2020-11-18 at 11 26 24

@jnweiger
Copy link
Contributor

jnweiger commented Dec 1, 2020

Retested with rc6

System language: German,
Einsteins selected language: French

image

We see a mixture of one third German, one third English and one third French.

Expected behaviour: Tutes francais!

@exalate-issue-sync
Copy link

Benedikt Kulmann commented: Changing the language only updates the left sidebar menu items on the first language switch (they should switch to a different language every time you change the language in settings). Sometimes (tm) there is a duplication of menu items after a language switch.

However, it looks like the left sidebar is the only component affected by this. The issue might be that we use the route path of menu items as their keys in the sidebar component and therefor it doesn't get re-rendered when the label changes: https://github.com/owncloud/owncloud-design-system/blob/4bd20916a903fd802e6d1a2f20c844ca88c279a2/src/components/OcSidebar.vue#L31

The remaining mix of languages is a result of missing translations in transifex.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants