Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text editor file path label #4391

Merged
merged 3 commits into from
Nov 26, 2020
Merged

Text editor file path label #4391

merged 3 commits into from
Nov 26, 2020

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Nov 25, 2020

Description

There might be cases where the markdown editor stripped the first actual character of a file or folder name. It was supposed to strip a leading slash/backslash. This PR only trims leading slashes or backslashes. As a quick win it also sets aria labels for components that were complaining in the JS console about not having aria labels.

Related Issue

Motivation and Context

Hardening.

How Has This Been Tested?

  • drone

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested review from LukasHirt and refs November 25, 2020 21:30
@kulmann kulmann self-assigned this Nov 25, 2020
@kulmann kulmann added the Status:Needs-Review Needs review from a maintainer label Nov 25, 2020
Copy link
Collaborator

@LukasHirt LukasHirt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@kulmann kulmann merged commit 7eae026 into master Nov 26, 2020
@delete-merged-branch delete-merged-branch bot deleted the text-editor-file-path-label branch November 26, 2020 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

File editor trims folder path start character
2 participants