Merge pull request #4391 from owncloud/text-editor-file-path-label

Text editor file path label

apps/markdown-editor/src/MarkdownEditor.vue

@@ -15,11 +15,11 @@
           name="input"
           full-width
           :value="currentContent"
+          :label="$gettext('Editor')"
           class="uk-height-1-1"
           :rows="20"
           @input="onType"
-        >
-        </oc-textarea>
+        />
       </div>
       <div class="uk-container uk-width-1-2">
         <!-- eslint-disable-next-line vue/no-v-html -->

apps/markdown-editor/src/MarkdownEditorAppBar.vue

@@ -5,10 +5,10 @@
         <oc-button :disabled="!isTouched" @click="saveContent">
           <oc-icon name="save" aria-hidden="true" />
         </oc-button>
-        <oc-spinner v-if="isLoading" />
+        <oc-spinner v-if="isLoading" :aria-label="$gettext('Loading editor content')" />
       </div>
       <div class="uk-width-expand uk-text-center">
-        <span>{{ activeFile.path.substr(1) }}</span>
+        <span>{{ activeFilePath }}</span>
       </div>
       <div class="uk-width-auto uk-text-right">
         <oc-button @click="closeApp">
@@ -24,7 +24,10 @@ import { mapGetters, mapActions } from 'vuex'
 export default {
   computed: {
     ...mapGetters(['activeFile']),
-    ...mapGetters('MarkdownEditor', ['isTouched', 'isLoading'])
+    ...mapGetters('MarkdownEditor', ['isTouched', 'isLoading']),
+    activeFilePath() {
+      return this.activeFile.path.replace(/^(\/|\\)+/, '')
+    }
   },
   methods: {
     ...mapActions('MarkdownEditor', ['saveFile']),

changelog/unreleased/text-editor-file-path-label

@@ -0,0 +1,5 @@
+Bugfix: Don't break file/folder names in text editor
+
+The label in the text editor that displays the path of the active file was removing the first character instead of trimming leading slashes. This might have lead to situations where actual characters were removed. We fixed this by only removing leading slahes instead of blindly removing the first character.
+
+https://github.com/owncloud/phoenix/pull/4391