Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wording of file action for opening PDFs in browser #4097

Merged
merged 1 commit into from
Sep 22, 2020

Conversation

kulmann
Copy link
Contributor

@kulmann kulmann commented Sep 22, 2020

Description

Align wording for opening PDFs with file actions involving extensions (Open in Mediaviewer etc).

Motivation and Context

Consistent naming.

Screenshots (if appropriate):

Screenshot 2020-09-22 at 13 55 47

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@kulmann kulmann requested a review from LukasHirt September 22, 2020 11:53
@kulmann kulmann self-assigned this Sep 22, 2020
@update-docs
Copy link

update-docs bot commented Sep 22, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann merged commit 20a66fd into master Sep 22, 2020
@delete-merged-branch delete-merged-branch bot deleted the open-pdf-wording branch September 22, 2020 13:04
@exalate-issue-sync exalate-issue-sync bot mentioned this pull request Oct 21, 2020
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants