PDF Viewer

[exalate-issue-sync]

Description

• Check the exisiting implementation
  • Implementation is broken
  • Seems that it cannot load the library
• Identify the missing tasks
• Research if browser PDF viewer is sufficient

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-46

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-46

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-46

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-46

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-46

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-46

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-46

[exalate-issue-sync]

Remote key is https://jira.owncloud.com/browse/OCIS-46

[LukasHirt]

The fix is here owncloud/web#3740 but there is still a lot of things that needs to be done with the PDF viewer so I am not sure if this issue should be closed after it gets merged. @micbar ideas?

[exalate-issue-sync]

Michael Barz commented: [~pmaier][~lhirt]
Next step: Identify the missing pieces
Then: Write issues, close this one

[exalate-issue-sync]

Lukas Hirt commented: I'll keep this issue opened as any follow up issues will depend on if we're going with default browser PDF viewer or with a custom one.

[exalate-issue-sync]

Lukas Hirt commented: I tested the browser PDF viewer in all major browsers (chrome, ff, edge, opera) and IMO it has a few advanteges and few disadvanteges:

Advanteges

• Less code maintanance on our side
• Users are not "forced" to use any specific PDF viewer since there are different pdf viewers plugins for browsers or desktop apps which can be integrated into browsers

Disadvanteges

• The issue with not being able to view/download attachments still persists (https://github.com/owncloud/enterprise/issues/3377)
• With custom PDF viewer we could introduce some light branding which wouldn't be possible with the browser one
• I can imagine users opening issues in ownCloud if something goes wrong in their browser which we couldn't really affect
• Same caveat as with download - we need to fetch the file so if it is a bigger file it could take a while and in this case it's hard to give some feedback to the user about loading (probably would be solved with the pre-signed URLs)

I haven't found any real issues with displaying PDF documents in mentioned browsers. I tried with different types - interactive ones, really big ones and one containing 3D objects and all got displayed. So I guess it only comes to comparing those advanteges and disadvanteges. If you'd know about any specific features that would need to be additionally tested just let me know. Otherwise pls let me know which direction we should start heading with the implementation [~mbarz] [~pmaier] [~pvince81]

[micbar]

@lhirt we have a special feature in our PDF viewer which displays embedded pdf files.
This is heavily used by some customers.

https://github.com/owncloud/enterprise/issues/3377

[LukasHirt]

@micbar Yes, that's what I meant with The issue with not being able to view/download attachments still persists (owncloud/enterprise/issues/3377). I forgot to write that it's disadvantage only of the browser one.

[LukasHirt]

Then if it's heavily used by some of the customers I'd say it's decided and we stick with the custom one?

[micbar]

@micbar Yes, that's what I meant with The issue with not being able to view/download attachments still persists (owncloud/enterprise/issues/3377). I forgot to write that it's disadvantage only of the browser one.

Sorry, i overlooked that 😄

[micbar]

Then if it's heavily used by some of the customers I'd say it's decided and we stick with the custom one?

Needs PB decision @pmaier1

[exalate-issue-sync]

Michael Barz commented: Research has been done - > closing this tickets needs follow up

[PVince81]

missing statement about decision @micbar

[pmaier1]

Native fist

• Easier
• Has a lot of advatages

Library can come later

[exalate-issue-sync]

Benedikt Kulmann commented: The pdf viewer app has been removed in owncloud/web#4076 and was replaced with an entry in the file actions context menu named Display PDF. This action just opens the PDF in a new browser tab to utilize native browser behaviour.
[~pmaier] [~mbarz]

[exalate-issue-sync]

Patrick Maier commented: Very nice, thank you! One remark: For other file viewers/editors we used to have an entry "Open in/with XY". Maybe we should go for "Open in Browser" instead of "Display PDF"?

[LukasHirt]

Implemented in owncloud/web#4076

[exalate-issue-sync]

Benedikt Kulmann commented: [~pmaier] fixed wording in owncloud/web#4097