Do not fallback to appId if the file action route is not defined #3740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kulmann
approved these changes
Jul 7, 2020
There was a problem hiding this comment.
cool 👍
We should aim for having proper URLs on opened resources in file viewers. This was recently implemented in mediaviewer by @dschmidt (reload page, still have the same file open in mediaviewer. this is broken in pdf-viewer etc). Will track that in a separate issue though. Good to have the pdf viewer working again. 🚀
Absolutely agree 👍 |
fyi, raised it in jira for next weeks product board https://jira.owncloud.com/browse/OC-2038 @LukasHirt |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When opening a file in a editor or a viewer the path was falling back to an appId.
This made it impossible to navigate via the file actions into an app which doesn't have duplicate appId in the route.
We've stopped falling back to this value and in case that the route of the file action is not defined, we use the root path of the app.
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes