Add favorites capabilities #3754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasHirt
force-pushed
the
feature/favorites-capabilities
branch
from
71efb51 to
37e9fbd
Compare
|
What should we do with tests here? @PVince81 @individual-it Should I just skip them until the new oC version? |
If the core PR gets merged today, then the code for exposing the favorites capability will be in the daily-master-qa tarball overnight. And running CI here tomorrow should pass. |
I see. Nice, thanks! |
|
PR was merged. please restart the build tomorrow... |
|
I restarted CI just now: https://drone.owncloud.com/owncloud/phoenix/10353 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We've added a check of favorites capabilities to enable disabling of favorites list and favorite action.
Related Issue
FavoritesthrowsLoading folder failed…ocis#354How Has This Been Tested?
Types of changes