Add favorites capabilities

owncloud · Jul 9, 2020 · 71efb51 · 71efb51
1 parent 6eee41e
commit 71efb51
Show file tree

Hide file tree

Showing 5 changed files with 24 additions and 4 deletions.
diff --git a/apps/files/src/components/FileDetails.vue b/apps/files/src/components/FileDetails.vue
@@ -20,7 +20,7 @@
         </div>
         <div v-if="$route.name !== 'files-shared-with-others'">
           <oc-star
-            v-if="!publicPage()"
+            v-if="!publicPage() && isFavoritesEnabled"
             id="files-sidebar-star-icon"
             class="uk-inline"
             :shining="highlightedFile.starred"
@@ -94,6 +94,10 @@ export default {
 
     activeTabComponent() {
       return this.fileSideBarsEnabled.find(sidebar => sidebar.app === this.currentTab)
+    },
+
+    isFavoritesEnabled() {
+      return this.capabilities.files && this.capabilities.files.favorites
     }
   },
   watch: {

diff --git a/apps/files/src/default.js b/apps/files/src/default.js
@@ -85,6 +85,9 @@ const navItems = [
     iconMaterial: 'star',
     route: {
       name: 'files-favorites'
+    },
+    enabled(capabilities) {
+      return capabilities.files && capabilities.files.favorites
     }
   },
   {

diff --git a/apps/files/src/fileactions.js b/apps/files/src/fileactions.js
@@ -39,7 +39,7 @@ export default {
             return this.$gettext('Mark as favorite')
           },
           isEnabled: () => {
-            return this.isAuthenticated
+            return this.isAuthenticated && this.capabilities.files.favorites
           }
         },
         {

diff --git a/changelog/unreleased/favorites-capabilities b/changelog/unreleased/favorites-capabilities
@@ -0,0 +1,6 @@
+Enhancement: Add favorites capabilities
+
+We've added a check of favorites capabilities to enable disabling of favorites list and favorite action.
+
+https://github.com/owncloud/ocis/issues/354
+https://github.com/owncloud/phoenix/pull/3754
diff --git a/src/store/navigation.js b/src/store/navigation.js
@@ -49,10 +49,17 @@ const getters = {
    * @param state
    * @returns {function(*): *[]}
    */
-  getNavItems: state => extension => {
+  getNavItems: (state, rootState) => extension => {
     const staticNavItems = state.staticNavItems[extension] || []
     const dynamicNavItems = state.dynamicNavItems[extension] || []
-    return [...staticNavItems, ...dynamicNavItems]
+
+    return [...staticNavItems, ...dynamicNavItems].filter(navItem => {
+      if (!navItem.enabled) {
+        return true
+      }
+
+      return navItem.enabled(rootState.capabilities)
+    })
   },
   /**
    * Get all extension ids that have at least one navigation item.