Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Tests-Only] Added acceptance test for changing existing expiration date on collaborator share #3157

Merged
merged 1 commit into from
Mar 12, 2020
Merged

[Tests-Only] Added acceptance test for changing existing expiration date on collaborator share #3157

merged 1 commit into from
Mar 12, 2020

Conversation

kiranparajuli589
Copy link
Contributor

@kiranparajuli589 kiranparajuli589 commented Mar 6, 2020 •
edited
Loading

Description

Acceptance test added for changing existing expiration date of an existing user/group share

Related Issue

Motivation and Context

How Has This Been Tested?

  • locally

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@kiranparajuli589 kiranparajuli589 self-assigned this Mar 6, 2020
@kiranparajuli589 kiranparajuli589 added the Status:Needs-Review Needs review from a maintainer label Mar 6, 2020
@kiranparajuli589 kiranparajuli589 linked an issue Mar 6, 2020 that may be closed by this pull request
More tests for collaborators expiration date #3132
Closed
5 tasks
@kiranparajuli589 kiranparajuli589 removed the request for review from DeepDiver1975 March 6, 2020 10:10
@kiranparajuli589 kiranparajuli589 mentioned this pull request Mar 6, 2020
Merged
10 tasks
jasson99
jasson99 reviewed Mar 6, 2020
View reviewed changes
Copy link
Contributor

@jasson99 jasson99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kiranparajuli589 kiranparajuli589 force-pushed the change-existing-expiration branch from 804ef17 to b65eda1 Compare March 10, 2020 03:29
@kiranparajuli589 kiranparajuli589 changed the title [Tests-Only] Added acceptance test for changing existing expiration date of a user… [Tests-Only] Added acceptance test for changing existing expiration date on collbaorator share Mar 11, 2020
@kiranparajuli589 kiranparajuli589 changed the title [Tests-Only] Added acceptance test for changing existing expiration date on collbaorator share [Tests-Only] Added acceptance test for changing existing expiration date on collaborator share Mar 11, 2020
@kiranparajuli589 kiranparajuli589 force-pushed the change-existing-expiration branch from b65eda1 to 735f875 Compare March 11, 2020 04:22
@kiranparajuli589 kiranparajuli589 requested review from individual-it and removed request for individual-it March 11, 2020 04:22
@kiranparajuli589 kiranparajuli589 force-pushed the change-existing-expiration branch 2 times, most recently from 036a0ed to 340abbc Compare March 11, 2020 08:51
@kiranparajuli589 kiranparajuli589 force-pushed the change-existing-expiration branch from 824b1ed to aa2c598 Compare March 12, 2020 03:53
@kiranparajuli589 kiranparajuli589 force-pushed the change-existing-expiration branch from aa2c598 to 608b23e Compare March 12, 2020 03:55
individual-it
individual-it approved these changes Mar 12, 2020
View reviewed changes
Copy link
Member

@individual-it individual-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please squash the commits before merging!

@kiranparajuli589 kiranparajuli589 force-pushed the change-existing-expiration branch from 608b23e to b1a13c5 Compare March 12, 2020 06:30
@kiranparajuli589 kiranparajuli589 force-pushed the change-existing-expiration branch from b1a13c5 to 0c933af Compare March 12, 2020 07:01
@kiranparajuli589 kiranparajuli589 merged commit c19224a into master Mar 12, 2020
@delete-merged-branch delete-merged-branch bot deleted the change-existing-expiration branch March 12, 2020 08:06
@LukasHirt LukasHirt mentioned this pull request Mar 16, 2020
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasson99 jasson99 jasson99 left review comments

@individual-it individual-it individual-it approved these changes

@dpakach dpakach Awaiting requested review from dpakach

@haribhandari07 haribhandari07 Awaiting requested review from haribhandari07

Assignees

@kiranparajuli589 kiranparajuli589

Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

More tests for collaborators expiration date
5 participants
@kiranparajuli589 @individual-it @dpakach @haribhandari07 @jasson99