More tests for collaborators expiration date

[LukasHirt]

Follow up on #3086

Needs to be implemented:

• Change of existing expiration date [Tests-Only] Added acceptance test for changing existing expiration date on collaborator share #3157 [Tests-Only] Add acceptance tests for collaborators share expiration date #3199
• Enforced expiration date Fix share expiration date change #3241 [Tests-Only] Add acceptance tests for enforced expiration on collaborators share #3159
• Group expiration date [Tests-Only] Added acceptance test for changing existing expiration date on collaborator share #3157
• Editing user and group shares when both have different default/enforced expiration dates - bug see user and group expiration dates do influence each-other #3174
• Expiration date gets displayed (unit test should be enough)

[individual-it]

@kiranparajuli589 @jasson99 how much of that issue is left to do?

[kiranparajuli589]

• Editing user and group when both have different default/enforced expiration dates

@individual-it @LukasHirt @jasson99
Is this really editing user/group or editing user/group shares??

[kulmann]

• Editing user and group when both have different default/enforced expiration dates

@individual-it @LukasHirt @jasson99
Is this really editing user/group or editing user/group shares??

This is editing of user-shares and group-shares. Expiration dates are defined separately for the two share types (but in the same manner for both).

We don't have user and group editing in Phoenix, yet. ;-)

[individual-it]

@LukasHirt what do you mean by the unit tests in Expiration date gets displayed (unit test should be enough)? AFAIK there are no unit tests in phoenix

[LukasHirt]

@individual-it Yeah, unit tests are not yet in place but we want to bring them soon (#2026). For now, I'd say we can postpone that one scenario. My main reason for doing this as a unit test is that acceptance tests would need to do some gymnastics to really test it reliably since the displayed expiration date changes depending on the time of the day. So it doesn't seem worth the effort to me. Unit tests should be perfectly enough IMHO.

[pascalwengerter]

Just fixed the selectors for expiration dates in the acceptance tests the other day so closing this as fixed :) we'll perhaps move some of it to unit tests soon, but let's open a new ticket for that when it gets relevant