Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust recycle scroller item size #3100

Merged
merged 4 commits into from
Mar 2, 2020
Merged

Adjust recycle scroller item size #3100

merged 4 commits into from
Mar 2, 2020

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Feb 27, 2020 •
edited
Loading

A recent library update in ODS for the recycle scroller seem to have
changed the logic or calculation of the height.

This fix accomodates for that change and restores the row height to a
correct value.

Description

Related Issue

Fixes #3099

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Before

image

After

image

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PVince81 PVince81 requested a review from LukasHirt February 27, 2020 12:02
@PVince81 PVince81 self-assigned this Feb 27, 2020
@update-docs
Copy link

update-docs bot commented Feb 27, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@PVince81 PVince81 mentioned this pull request Feb 27, 2020
Closed
2 tasks
LukasHirt
LukasHirt previously approved these changes Feb 27, 2020
View reviewed changes
@PVince81
Copy link
Contributor Author

restarted build

@PVince81
Copy link
Contributor Author

tests/acceptance/features/webUISharingInternalGroups/shareWithGroups.feature:63

@PVince81
Copy link
Contributor Author

test also fails consistently locally.

when I revert the row height change it passes again.

really weird, maybe related to the "scroll to" logic

@PVince81
Copy link
Contributor Author

with VNC enabled, the test passes... maybe because it runs slower :'(

@PVince81
Copy link
Contributor Author

now cannot reproduce it locally any more. I was about to use a trick: add a this.pause(60000) in the error condition, with VNC off, then connect VNC as soon as it runs into that block.

maybe next time...

Adjust recycle scroller item size
678fe5a 
A recent library update in ODS for the recycle scroller seem to have
changed the logic or calculation of the height.

This fix accomodates for that change and restores the row height to a
correct value.
@PVince81
Copy link
Contributor Author

PVince81 commented Mar 2, 2020

rebased and added changelog.

somehow I can't reproduce the failure locally any more... :-/

@PVince81
Copy link
Contributor Author

PVince81 commented Mar 2, 2020

hmmm, and now suddenly the file actions tests have trouble finding the button with iphone: tests/acceptance/features/webUIRestrictSharing/restrictReSharing.feature:21

but it worked before the last rebase 🤦‍♂️

@PVince81
Copy link
Contributor Author

PVince81 commented Mar 2, 2020

seems like a legit fail, locally reproducible... but not sure why it only starts happening here

the three dots are not visible:
image

I'll remove the Owner column in responsive mode. Not sure why it wasn't removed like the Collaborators one.

Vincent Petry added 3 commits March 2, 2020 16:30
Make shared file lists more responsive
7bcae0d 
Remove share time and collaborators/owner columns on small screens.

Fixes test issues with iPhone form factor where the file actions button
was not visible any more.
Fix tests to wait for files scroll container
7a7b9bd 
Wait for virtual scroller to appear before attempting to scroll, as
sometimes it is not initialized yet despite the table container being
visible already.

Fixes some issues where the scroll container was not found within the
JS scrolling code that is run in the browser.
Exclude changelog folder from webpack watcher
31b966d
@PVince81
Copy link
Contributor Author

PVince81 commented Mar 2, 2020

Test should pass now after fixing responsive mode for shared file lists.

Also fixed tests to properly wait for the file list recycle scroller to be visible.

Bonus: removed changelog from webpack watcher.

@PVince81 PVince81 dismissed LukasHirt’s stale review March 2, 2020 15:34

More changes to review now

@LukasHirt LukasHirt merged commit 196d1a1 into master Mar 2, 2020
@LukasHirt LukasHirt deleted the fix-row-height branch March 2, 2020 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LukasHirt LukasHirt LukasHirt approved these changes

@DeepDiver1975 DeepDiver1975 Awaiting requested review from DeepDiver1975

Assignees

@PVince81 PVince81

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

File list row heights is bigger than expected
2 participants
@PVince81 @LukasHirt