Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

File list row heights is bigger than expected #3099

Closed
2 tasks
PVince81 opened this issue Feb 27, 2020 · 5 comments · Fixed by #3100
Closed
2 tasks

File list row heights is bigger than expected #3099

PVince81 opened this issue Feb 27, 2020 · 5 comments · Fixed by #3100
Assignees
Labels
Type:Bug Something isn't working

Comments

@PVince81
Copy link
Contributor

image

This is on master (53c5d4a).

The row heights used to be smaller.
The issue might be due to the ODS update.

I had a look at the DOM tree and didn't find any element that is causing this, as the row contents has the correct height. Somehow it's the virtual scroll row element that is bigger.

  • bisect to find origin
  • fix it
@PVince81
Copy link
Contributor Author

it looks the same when switching from master to v0.4.0 without running yarn install.

this confirms that the ODS lib updates are likely causing this issue

@PVince81
Copy link
Contributor Author

there is no element that is pushing the height.
here is the top most element:
image

the parent of it is the virtual scroller container itself

@PVince81
Copy link
Contributor Author

This is really weird... Even if I delete all DOM elements inside, it still keeps the height.
And I can't find any CSS property that is setting this specific height...

Right, it's rather the calculated "translateY" property that shifts the rows.
Need to find out on what this value is based.

@PVince81
Copy link
Contributor Author

Calculation is here: https://github.com/Akryum/vue-virtual-scroller#how-does-it-work

Ok, so the solution is to setting "item-size" to 55 instead of 70. The rows then look narrower.
I'll do just that...

@PVince81 PVince81 self-assigned this Feb 27, 2020
@PVince81
Copy link
Contributor Author

Fix is here: #3100

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant