Fix add/remove animations for collaborators and links

[kulmann]

Detailed Description

Collaborator and link forms (adding/editing) unnecessarily trigger mutations on loading states (SHARES_LOADING and LINKS_LOADING). This causes animations for adding and removing collaborators/links to fail in the respective panels. While fixing this, some old code has been cleaned up as well.

• removed triggers for busy-state for collaborator and link saving/creating. using local variable in respective form components now. This fixes the animations in the sidebar panels when adding or removing items, as the loader is not triggered anymore. As saving can be represented within the respective form, there is no need to push this state into the store.
• removed unused code in collaborator editing form
• changed buttons in collaborator forms to represent a saving-state when still in saving mode
• re-introduced a data change detection for collaborators.
• switched promise handling when adding collaborators to using p-queue

Related Issue

• Fixes Animations broken on adding/deleting public links or collaborators #2937

Motivation and Context

Fix animations and clean up old code.

How Has This Ben Tested?

• local in Chrome and Firefox
• selenium

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)
• Technical debt
• Tests

Checklist:

• Code changes
• Unit tests added
• Acceptance tests added
• Documentation ticket raised:

[update-docs]

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

[PVince81]

Code looks good.

However somehow now when deleting a collaborator or link there is a small 1-2 second delay where nothing happens until the animation begins. I think we do need some kind of spinner there, ideally also something that locks the row so one cannot click twice on delete.

[kulmann]

@PVince81 The removal on a public link or collaborator now shows a loading spinner where the delete button was before, as soon as delete is clicked. The edit button is removed from the ui at the same time. Another thing I noticed is, that the first add and last removal didn't trigger the animation. Fixed that as well. Please re-review. :-)

[PVince81]

As discussed, let's align the spinner sizes with the icon sizes in ODS

[PVince81]

Just tested, looks fine as you said.

I've raised owncloud/owncloud-design-system#631 to align spinner sizes with icon sizes.

[PVince81]

👍