You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When a public link or collaborator is added or removed, the transition-group on the respective list can't do it's job (sliding in the new list item / out the removed one) because the links/shares receive a LINKS_LOADING / SHARES_LOADING state in the store. I think we're overusing the mutation - the animation would already do the job of showing a change in the respective list UI. Triggering the loading progress bar through the mutation is a) not necessary and b) (more important) disrupts the UI, as the whole panel is hidden while the loader is shown.
I would like to remove the mutation on adding and removing links/collaborators. Thoughts and concerns about this?
The text was updated successfully, but these errors were encountered:
When a public link or collaborator is added or removed, the
transition-group
on the respective list can't do it's job (sliding in the new list item / out the removed one) because the links/shares receive aLINKS_LOADING
/SHARES_LOADING
state in the store. I think we're overusing the mutation - the animation would already do the job of showing a change in the respective list UI. Triggering the loading progress bar through the mutation is a) not necessary and b) (more important) disrupts the UI, as the whole panel is hidden while the loader is shown.I would like to remove the mutation on adding and removing links/collaborators. Thoughts and concerns about this?
The text was updated successfully, but these errors were encountered: