Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit concurrent uploads to one #2653

Merged
merged 1 commit into from
Dec 10, 2019
Merged

Limit concurrent uploads to one #2653

merged 1 commit into from
Dec 10, 2019

Conversation

PVince81
Copy link
Contributor

@PVince81 PVince81 commented Dec 9, 2019

Description

Limit concurrent uploads to one to avoid clogging the network queue of the browser.
The progress bar is still added before the upload actually starts, but the SDK upload method is called only once the p-queue triggers it when it's its turn.

Related Issue

Fixes #2594

Motivation and Context

Unclog the browser network queue

How Has This Been Tested?

  • Test case 1: upload many files in regular files view and observe the network console:
    • before the fix: a lot of pending entries, laptop fan going crazy
    • after the fix: only one pending upload network call at a time
  • Test case 2: like test case 1 but using the "upload-only" public link share (aka files-drop) because this has another code path

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Dec 9, 2019
@PVince81 PVince81 requested a review from LukasHirt December 9, 2019 17:11
@PVince81 PVince81 self-assigned this Dec 9, 2019
@PVince81 PVince81 merged commit 7d05cb0 into master Dec 10, 2019
@delete-merged-branch delete-merged-branch bot deleted the limit-uploads-concurrency branch December 10, 2019 08:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit for simultaneous uploads
2 participants