Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit for simultaneous uploads #2594

Closed
PVince81 opened this issue Nov 29, 2019 · 6 comments · Fixed by #2653
Closed

Limit for simultaneous uploads #2594

PVince81 opened this issue Nov 29, 2019 · 6 comments · Fixed by #2653
Labels
feature:files Priority:p2-high Escalation, on top of current planning, release blocker Type:Technical-Debt

Comments

@PVince81
Copy link
Contributor

In OC 10 we only ever upload a single file, no parallelism.

In Phoenix the upload is running in parallel.

To avoid overloading the network queue, we should add a limit to the number of parallel requests.
I wonder if we should just make it one, at least for now.

@DeepDiver1975

@PVince81
Copy link
Contributor Author

Also need to check for other operations like deleting files, trashbin, etc

We need a generic mechanism for such operations.

@PVince81 PVince81 added this to the Milestone 1: Phoenix for users milestone Nov 29, 2019
@PVince81
Copy link
Contributor Author

This is needed also to avoid blocking important requests like token refresh requests.

@PVince81
Copy link
Contributor Author

As discussed internally, let's make it one for now. A simple queue should be enough.

We can look into more clever parallelization later on. I'd see chunking has higher priority (even sequential) before parallelization.

@PVince81 PVince81 added the Priority:p2-high Escalation, on top of current planning, release blocker label Nov 29, 2019
@PVince81
Copy link
Contributor Author

PVince81 commented Dec 9, 2019

As far as I can see we already have a p-queue (promise queue) in place for directory uploads, but it isn't used for regular uploads.

We should consolidate all those mechanisms.

Basically only have a single p-queue for all uploads, which can also be filled later on if the user adds more uploads while current uploads are running.

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 9, 2019

correction, the p-queue is only used for creating folders that originate from a directory upload.

the upload of files there is still happening in parallel

@PVince81
Copy link
Contributor Author

PVince81 commented Dec 9, 2019

PR here: #2653

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature:files Priority:p2-high Escalation, on top of current planning, release blocker Type:Technical-Debt
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant