-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Limit for simultaneous uploads #2594
Comments
Also need to check for other operations like deleting files, trashbin, etc We need a generic mechanism for such operations. |
This is needed also to avoid blocking important requests like token refresh requests. |
As discussed internally, let's make it one for now. A simple queue should be enough. We can look into more clever parallelization later on. I'd see chunking has higher priority (even sequential) before parallelization. |
As far as I can see we already have a p-queue (promise queue) in place for directory uploads, but it isn't used for regular uploads. We should consolidate all those mechanisms. Basically only have a single p-queue for all uploads, which can also be filled later on if the user adds more uploads while current uploads are running. |
correction, the p-queue is only used for creating folders that originate from a directory upload. the upload of files there is still happening in parallel |
PR here: #2653 |
In OC 10 we only ever upload a single file, no parallelism.
In Phoenix the upload is running in parallel.
To avoid overloading the network queue, we should add a limit to the number of parallel requests.
I wonder if we should just make it one, at least for now.
@DeepDiver1975
The text was updated successfully, but these errors were encountered: