Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/logout on access denied page #2178

Merged
merged 1 commit into from
Oct 9, 2019

Conversation

DeepDiver1975
Copy link
Member

@DeepDiver1975 DeepDiver1975 commented Oct 8, 2019

Description

  1. there is a logout link now in the access denied page including some descriptive text about it
  2. themable helpdesk message now translated

How to test

  • add following to themes/owncloud.json file
{
  "general": {
    "name": "ownCloud",
    "slogan": "ownCloud – A safe home for all your data",
    "helpDeskText": {
      "en": "You are not one of the 300 Spartans, if you think this message shows up in error please contact King Leonidas",
      "de": "Sie keiner der 300 Spartiaten. Wenn Sie der Meinung sind, dass diese Meldung irrtümlich angezeigt wird, wenden Sie sich bitte an König Leonidas"
    },
  },
  "logo": {
    "favicon": "themes/owncloud/favicon.jpg"
  }
}

Screenshots (if appropriate):

Screenshot from 2019-10-08 16-58-07

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Open tasks:

  • ...

@DeepDiver1975 DeepDiver1975 added the Status:Needs-Review Needs review from a maintainer label Oct 8, 2019
@DeepDiver1975 DeepDiver1975 self-assigned this Oct 8, 2019
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/logout-on-accessDenied-page branch from 87a1283 to d5f987c Compare October 8, 2019 15:01
@ownclouders
Copy link
Contributor

💥 Acceptance tests webUIPrivateLinks failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5558/

20191008-151210-036.png
20191008-151210-310.png
20191008-151253-321.png

src/pages/accessDenied.vue Outdated Show resolved Hide resolved
src/pages/accessDenied.vue Outdated Show resolved Hide resolved
@ownclouders
Copy link
Contributor

💥 Acceptance tests XGAPortrait failed. Please find the screenshots inside ...

https://drone.owncloud.com/owncloud/phoenix/5562/

20191008-155504-497.png
20191008-155534-944.png
20191008-155603-988.png
20191008-160858-769.png
20191008-160923-803.png
20191008-161009-009.png
20191008-161043-944.png
20191008-161108-818.png
20191008-161134-576.png
20191008-161209-473.png
20191008-161235-466.png
20191008-161343-974.png
20191008-161344-235.png
20191008-161412-034.png
20191008-161412-410.png
20191008-161447-146.png
20191008-161447-385.png
20191008-161515-094.png
20191008-161515-289.png

Support help desk text to be translated
@DeepDiver1975 DeepDiver1975 force-pushed the bugfix/logout-on-accessDenied-page branch from d5f987c to 5d91335 Compare October 9, 2019 07:17
@DeepDiver1975
Copy link
Member Author

fixes #2102

@DeepDiver1975 DeepDiver1975 merged commit 25f71e7 into master Oct 9, 2019
@delete-merged-branch delete-merged-branch bot deleted the bugfix/logout-on-accessDenied-page branch October 9, 2019 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status:Needs-Review Needs review from a maintainer
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants