Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to authorisation at access denied page #2102

Closed
LukasHirt opened this issue Sep 30, 2019 · 3 comments
Closed

Link to authorisation at access denied page #2102

LukasHirt opened this issue Sep 30, 2019 · 3 comments
Assignees
Labels
Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task Type:Design

Comments

@LukasHirt
Copy link
Collaborator

There is no "easy" way of navigating back to authorisation page if the user lands on the access denied page. Let's add a simple link to get there.

@LukasHirt LukasHirt added Category:Enhancement Add new functionality Type:Design Topic:good-first-issue beginner friendly task labels Sep 30, 2019
@LukasHirt LukasHirt added this to the backlog milestone Sep 30, 2019
@DeepDiver1975
Copy link
Member

I understand that this is specifically annoying for us during development and Testing.
In a real world scenario any further action will Not Help.
The user is authenticated at the idp Level.
Bringing the user back to the logon page will sugerate that there is a was Out. Nur there isnt. 🤷

@LukasHirt
Copy link
Collaborator Author

Since you can land on that page in case of any error I think it would be nice addition. E. g. if the token expired and user needs to authorise again. But you have a point there about the way out. Also question is how many of those errors will still be there when Phoenix is "ready" for users.

@DeepDiver1975
Copy link
Member

Assuming that we will implement PKCE within owncloud oauth this page will usually never be visible in regular use.

@DeepDiver1975 DeepDiver1975 self-assigned this Oct 9, 2019
@DeepDiver1975 DeepDiver1975 modified the milestones: backlog, Milestone 1: Phoenix for users Oct 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category:Enhancement Add new functionality Topic:good-first-issue beginner friendly task Type:Design
Projects
None yet
Development

No branches or pull requests

2 participants