Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app store app #11302

Merged
merged 30 commits into from
Aug 6, 2024
Merged
Changes from 1 commit
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
71a6bf6
feat: bootstrap app store app
kulmann Jul 30, 2024
075def5
feat: convert to tiles view
kulmann Jul 31, 2024
bd244fa
fix: hide text input clear button when initialized with empty string
kulmann Aug 1, 2024
5395d88
fix: re-add mark.js to users list for display name
kulmann Aug 1, 2024
f49f448
feat: allow default app store repo in csp.yaml
kulmann Aug 1, 2024
13c1a6b
feat: add basic client side search to app listing
kulmann Aug 1, 2024
670558e
fix: set fixed image aspect ratio and style fallback icon
kulmann Aug 1, 2024
a121fb0
feat: add app details page
kulmann Aug 1, 2024
b6daee0
feat: introduce layout component which also loads all apps
kulmann Aug 2, 2024
4e1aa33
feat: styling and more details
kulmann Aug 2, 2024
39d6656
fix hilighted mark item not visible in title
AlexAndBear Aug 3, 2024
444c5bd
Add background to app details to make it look less empty
AlexAndBear Aug 3, 2024
78cb54b
Fix search in app details on tag click not possible
AlexAndBear Aug 3, 2024
81c3b08
Add missing types as per pr review
AlexAndBear Aug 3, 2024
be50a90
fix: empty filter persists in url query
AlexAndBear Aug 3, 2024
d4c5316
Fix: mark doesn't work when enter route with filter term query
AlexAndBear Aug 3, 2024
89ed4c4
feat: align details style with AppTile style
kulmann Aug 5, 2024
e77b97e
feat: show screenshots in app details
kulmann Aug 5, 2024
5c01baf
Fix: make tags emit click event instead of search event, as it shoudn…
AlexAndBear Aug 5, 2024
eb1fc0b
feat: restyle image navigation
kulmann Aug 6, 2024
6b7b146
ci: add app store url to csp.yaml files
kulmann Aug 6, 2024
57fa5bc
refactor: use app-loading-spinner instead of custom component
kulmann Aug 6, 2024
eb6e81b
docs: add changelog item
kulmann Aug 6, 2024
d2203d9
feat: set up translations
kulmann Aug 6, 2024
5abca40
fix: lint
kulmann Aug 6, 2024
32f7244
feat: restyle image nav background
kulmann Aug 6, 2024
f9d342f
fix: types
kulmann Aug 6, 2024
637027d
fix: test behaviour regarding empty string in OcTextInput
kulmann Aug 6, 2024
af6ba27
feat: make image nav background more opaque
kulmann Aug 6, 2024
853b4da
feat: add contextual helper link to page titles
kulmann Aug 6, 2024
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix: make tags emit click event instead of search event, as it shoudn…
…'t make assumptions
AlexAndBear authored and kulmann committed Aug 6, 2024

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
commit 5c01bafe5dc844b75f1d4d159650ee28fbdfdf83
10 changes: 5 additions & 5 deletions packages/web-app-app-store/src/components/AppTags.vue
Original file line number Diff line number Diff line change
@@ -6,7 +6,7 @@
size="small"
class="oc-text-nowrap"
type="button"
@click="emitSearchTerm(tag)"
@click="emitClick(tag)"
>
<span class="mark-element">{{ tag }}</span>
</oc-tag>
@@ -24,14 +24,14 @@ export default defineComponent({
required: true
}
},
emits: ['search'],
emits: ['click'],
setup(props, { emit }) {
const emitSearchTerm = (term: string) => {
emit('search', term)
const emitClick = (tagName: string) => {
emit('click', tagName)
}
return {
emitSearchTerm
emitClick
}
}
})
2 changes: 1 addition & 1 deletion packages/web-app-app-store/src/components/AppTile.vue
Original file line number Diff line number Diff line change
@@ -19,7 +19,7 @@
</div>
<p class="oc-my-s mark-element">{{ app.subtitle }}</p>
</div>
<app-tags :app="app" @search="emitSearchTerm" />
<app-tags :app="app" @click="emitSearchTerm" />
<app-actions :app="app" />
</div>
</li>
2 changes: 1 addition & 1 deletion packages/web-app-app-store/src/views/AppDetails.vue
Original file line number Diff line number Diff line change
@@ -21,7 +21,7 @@
</div>
<div v-if="app.tags">
<h3>{{ $gettext('Tags') }}</h3>
<app-tags :app="app" @search="onTagClicked" />
<app-tags :app="app" @click="onTagClicked" />
</div>
<div v-if="app.authors">
<h3>{{ $gettext('Author') }}</h3>