Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: app store app #11302

Merged
merged 30 commits into from
Aug 6, 2024
Merged

feat: app store app #11302

merged 30 commits into from
Aug 6, 2024

Conversation

kulmann
Copy link
Member

@kulmann kulmann commented Jul 30, 2024

Description

New app store app

Related Issue

  • submarine

Motivation and Context

Make Web great again

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests
  • Documentation
  • Maintenance (e.g. dependency updates or tooling)

Open Tasks

  • tiles view
    • show tags
  • app details page
    • screenshots
    • long description
    • full version history
  • search

Copy link

update-docs bot commented Jul 30, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kulmann kulmann force-pushed the app-store branch 2 times, most recently from fc8704a to 04dd2d2 Compare July 30, 2024 15:31
Copy link
Member

@dschmidt dschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

packages/web-app-app-store/src/index.ts Outdated Show resolved Hide resolved
packages/web-app-app-store/src/piniaStores/apps.ts Outdated Show resolved Hide resolved
packages/web-app-app-store/src/piniaStores/apps.ts Outdated Show resolved Hide resolved
@kulmann kulmann force-pushed the app-store branch 4 times, most recently from 8a49fe3 to 43649da Compare August 1, 2024 10:27
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love it! 😍

What do you think about debouncing the initial loading state a bit? I always see this blue box showing up for a split-second.

dev/docker/ocis/csp.yaml Outdated Show resolved Hide resolved
packages/web-app-app-store/src/index.ts Outdated Show resolved Hide resolved
packages/web-app-app-store/src/views/AppList.vue Outdated Show resolved Hide resolved
@AlexAndBear
Copy link
Contributor

The app details view looks a little empty, I would suggest smth like that:

image

image

@AlexAndBear AlexAndBear self-requested a review August 3, 2024 20:20
@kulmann
Copy link
Member Author

kulmann commented Aug 6, 2024

What do you think about debouncing the initial loading state a bit? I always see this blue box showing up for a split-second.

Went back to using the good old app-loading-spinner component. Showing text content feels just like too complex for a simple loading state.

@kulmann kulmann marked this pull request as ready for review August 6, 2024 04:43
@@ -0,0 +1,113 @@
<template>
<div class="app-list oc-mb-m">
<h2 class="oc-mt-rm" v-text="$gettext('App Store')" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd suggest adding a link to the install guides for apps here? I naively thought I'd install them directly into my instance and was a bit surprised when it "just" downloaded a zip file 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Phase 1 is discovery, phase 2 is easy install, we need backend features for phase 2.

Do you have a good idea where to put such a link? It would be helpful indeed...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess an ℹ️ icon next to the heading with a tooltip that provides a link to https://owncloud.dev/services/web/#loading-applications would suffice for now?

Copy link
Contributor

@AlexAndBear AlexAndBear left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At this point it looks pretty mature to me 👍

I suggested to add a link to our docs, so the user knows how to install a an app.

Maybe we can add a context helper next to the download buttons or a link with text (How to install) under them.

Approving anyways

Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super awesome! 🚀

Copy link

sonarqubecloud bot commented Aug 6, 2024

@kulmann kulmann enabled auto-merge (squash) August 6, 2024 12:55
@kulmann kulmann merged commit 376d3df into master Aug 6, 2024
3 checks passed
@kulmann kulmann deleted the app-store branch September 5, 2024 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants