Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: preview app while sidebar being opened #10152

Merged
merged 11 commits into from
Dec 12, 2023
Merged

fix: preview app while sidebar being opened #10152

merged 11 commits into from
Dec 12, 2023

Conversation

JammingBen
Copy link
Contributor

@JammingBen JammingBen commented Dec 12, 2023 •
edited by kulmann
Loading

Description

Follow-up for #10111.

Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

@JammingBen JammingBen self-assigned this Dec 12, 2023
@update-docs Update Docs
Copy link

update-docs bot commented Dec 12, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@JammingBen JammingBen marked this pull request as ready for review December 12, 2023 15:18
kulmann
kulmann approved these changes Dec 12, 2023
View reviewed changes
Copy link
Member

@kulmann kulmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice followups, thank you 💪

@kulmann kulmann enabled auto-merge December 12, 2023 15:39
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 12, 2023

Quality Gate Failed Quality Gate failed

Failed conditions

0.0% Condition Coverage on New Code (required ≥ 50%)

See analysis details on SonarCloud

@kulmann kulmann merged commit 158624b into master Dec 12, 2023
2 of 3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix-preview-app-sidebar branch December 12, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kulmann kulmann kulmann approved these changes

Assignees

@JammingBen JammingBen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Preview app] image preloading broken
2 participants
@JammingBen @kulmann