Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Preview app] image preloading broken #9838

Closed
kulmann opened this issue Oct 23, 2023 · 1 comment · Fixed by #10152
Closed

[Preview app] image preloading broken #9838

kulmann opened this issue Oct 23, 2023 · 1 comment · Fixed by #10152
Assignees
@jacob-nv
Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working

Comments

@kulmann
Copy link
Member

kulmann commented Oct 23, 2023 •
edited
Loading

Steps to reproduce

  1. Upload some images
  2. Open one of the in the preview app
  3. Observe the network requests, images get preloaded

Expected behaviour

Navigating from the current image to the next or previous doesn't fetch the image and doesn't show a loading spinner

Actual behaviour

Navigating from the current image to the next or previous fetches the image something (again?!) and shows a loading spinner
@kulmann kulmann added Type:Bug Something isn't working Priority:p3-medium Normal priority labels Oct 23, 2023
@github-project-automation github-project-automation bot moved this to Qualification in Web Support Board Oct 23, 2023
@kulmann kulmann moved this from Qualification to Bugs Prio 3 or less in Web Support Board Oct 23, 2023
@kulmann kulmann moved this from Qualification to Prio 3 or less in Infinite Scale Team Board Oct 27, 2023
@jacob-nv
Copy link
Contributor

jacob-nv commented Nov 3, 2023 •
edited
Loading

@kulmann

Images are not getting fetched again. Those images comes form URL so if you have disabled cached, you will download it again.
Request coming from switching between images are PROPFIND requests.
Why the spinner is still displaying comes down to 2 things.

  1. Somewhat of a fake timeout
    fake_timeout
  2. Setting image as active
    set_image

Both of these states contribute to spinner displaying
spinner-condition

The timeout could be removed if activeMediaFileCached exists

@kulmann kulmann mentioned this issue Dec 12, 2023
Merged
5 tasks
@JammingBen JammingBen moved this from Prio 3 or less to In progress in Infinite Scale Team Board Dec 12, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Dec 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jacob-nv jacob-nv

Labels
Priority:p3-medium Normal priority Type:Bug Something isn't working
Projects
Infinite Scale Team Board
Archived in project
Web Support Board
Status: Bugs Prio 3 or less
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: preview app while sidebar being opened owncloud/web
2 participants
@kulmann @jacob-nv