Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable AppBanner #10034

Merged
merged 3 commits into from
Nov 23, 2023
Merged

Disable AppBanner #10034

merged 3 commits into from
Nov 23, 2023

Conversation

lookacat
Copy link
Contributor

Description

See #10015

Related Issue

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@update-docs Update Docs
Copy link

update-docs bot commented Nov 22, 2023

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@lookacat lookacat marked this pull request as ready for review November 22, 2023 11:12
JammingBen
JammingBen suggested changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@JammingBen JammingBen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a sentence to the dev docs to explain that not setting this in the theme.json will result in disabling the banner. We already have a section somewhere on the theme page I believe.

@lookacat lookacat enabled auto-merge (squash) November 23, 2023 10:17
@sonarqubecloud SonarQubeCloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@lookacat lookacat merged commit 257f0d2 into master Nov 23, 2023
@delete-merged-branch delete-merged-branch bot deleted the disable-app-banner branch November 23, 2023 14:00
ownclouders pushed a commit that referenced this pull request Nov 23, 2023
@lookacat
Disable AppBanner (#10034)
d5c4c46 
* Disable AppBanner

* Rename to isAppBannerAvailable

* Add to docs
AlexAndBear pushed a commit that referenced this pull request Dec 13, 2023
@lookacat @AlexAndBear
Disable AppBanner (#10034)
9551012 
* Disable AppBanner

* Rename to isAppBannerAvailable

* Add to docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexAndBear AlexAndBear AlexAndBear approved these changes

@JammingBen JammingBen JammingBen approved these changes

@kulmann kulmann Awaiting requested review from kulmann

@pascalwengerter pascalwengerter Awaiting requested review from pascalwengerter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[web] Disable App Banner
5 participants
@lookacat @kulmann @pascalwengerter @AlexAndBear @JammingBen