Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[web] Disable App Banner #10015

Closed
tbsbdr opened this issue Nov 20, 2023 · 7 comments · Fixed by #10034
Closed

[web] Disable App Banner #10015

tbsbdr opened this issue Nov 20, 2023 · 7 comments · Fixed by #10034
Assignees
Labels
Type:Story User Story

Comments

@tbsbdr
Copy link
Contributor

tbsbdr commented Nov 20, 2023

Issue Description

The app banner is not in shape for a public release. It would need further improvements, which we can't schedule right now, as the priority for the feature is too low.

Please track times

Requirement / acceptance criterion

  • Don't show the app banner if the appBanner key is missing or empty in the theme.json.
  • adjust in dev docs how to enable/disable the feature
@tbsbdr
Copy link
Contributor Author

tbsbdr commented Nov 20, 2023

cc @michaelstingl

@tbsbdr tbsbdr moved this from Qualification to Backlog in Infinite Scale Team Board Nov 20, 2023
@michaelstingl
Copy link
Contributor

@tbsbdr aren't current config options sufficient? Isn't there an option to disable it?

@tbsbdr
Copy link
Contributor Author

tbsbdr commented Nov 20, 2023

naa, there is no option to disable it 😢

@AlexAndBear
Copy link
Contributor

We could add an option alternatively?

@michaelstingl
Copy link
Contributor

Yes, config option please, and keep it enabled on our continuous deployments. This way, the teams can continue iterate on it and improve.

@AlexAndBear
Copy link
Contributor

Let's discuss this in spring planning today

@kulmann
Copy link
Member

kulmann commented Nov 21, 2023

Thanks for feedback, I updated the issue description accordingly. We need to decide if we want to put disabling the app banner into the config.json where we would usually do something like that or into the theme.json where all the app banner info lives.

@micbar micbar added the Type:Story User Story label Nov 21, 2023
@kulmann kulmann changed the title Disable App Banner [web] Disable App Banner Nov 21, 2023
@lookacat lookacat moved this from Backlog to In progress in Infinite Scale Team Board Nov 22, 2023
@lookacat lookacat self-assigned this Nov 22, 2023
@lookacat lookacat mentioned this issue Nov 22, 2023
9 tasks
@github-project-automation github-project-automation bot moved this from In progress to Done in Infinite Scale Team Board Nov 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

6 participants