-
Notifications
You must be signed in to change notification settings - Fork 159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[web] Disable App Banner #10015
Comments
@tbsbdr aren't current config options sufficient? Isn't there an option to disable it? |
naa, there is no option to disable it 😢 |
We could add an option alternatively? |
Yes, config option please, and keep it enabled on our continuous deployments. This way, the teams can continue iterate on it and improve. |
Let's discuss this in spring planning today |
Thanks for feedback, I updated the issue description accordingly. We need to decide if we want to put disabling the app banner into the config.json where we would usually do something like that or into the theme.json where all the app banner info lives. |
Issue Description
The app banner is not in shape for a public release. It would need further improvements, which we can't schedule right now, as the priority for the feature is too low.
Please track times
Requirement / acceptance criterion
appBanner
key is missing or empty in the theme.json.The text was updated successfully, but these errors were encountered: