Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] make Search more greedy #212

Merged
merged 3 commits into from
Dec 1, 2021
Merged

[Feature] make Search more greedy #212

merged 3 commits into from
Dec 1, 2021

Conversation

micbar
Copy link
Contributor

@micbar micbar commented Jun 8, 2021 •
edited by JammingBen
Loading

Modify the query

Outline

We change the internal query language to craft together a query which uses every term as string with trailing wildcards search_string

A list of strings lorem ipsu will be sent so the server as => lorem* ipsu*.

Users are also able to set wildcards on their own, e.g. *lorem* *ipsu*.

will fix two long standing issues @pmaier1 @EParzefall @mmattel

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 8, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@micbar micbar mentioned this pull request Sep 2, 2021
Closed
42 tasks
@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-master-firefox-mysql8.0-php7.2-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1689/19/1

@micbar micbar force-pushed the query-string branch 4 times, most recently from d2a2322 to f4c2866 Compare September 6, 2021 11:52
@micbar micbar changed the title use SimpleQueryString search [Feature] use SimpleQueryString search Sep 6, 2021
@micbar micbar self-assigned this Sep 6, 2021
@ownclouders
Copy link

💥 Acceptance tests pipeline apiLimitSearches-latest-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1702/20/1

@micbar micbar force-pushed the query-string branch 2 times, most recently from 5fd8267 to 9039d23 Compare September 7, 2021 14:49
@ownclouders
Copy link

💥 Acceptance tests pipeline apiSearchElastic-latest-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1705/22/1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 7, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@ownclouders
Copy link

💥 Acceptance tests pipeline apiSearchElastic-master-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1706/21/1

@jnweiger
Copy link
Contributor

@mmattel Doc attention: This changes end user behaviour.

@mmattel
Copy link
Contributor

mmattel commented Oct 14, 2021

Great change !
Adding @EParzefall 😃

@mmattel mmattel mentioned this pull request Oct 23, 2021
Merged
@mmattel
Copy link
Contributor

mmattel commented Oct 23, 2021

@micbar it would be great this PR can be finalized so we can use the operators in docs.
We are close to final for the upgraded search document and missing this is not good...

@micbar micbar changed the title [Feature] use SimpleQueryString search [Feature] make Search more greedy Oct 29, 2021
@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-master-firefox-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1772/16/1

@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-latest-firefox-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1772/18/1

@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-latest-chrome-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1773/17/1

@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-master-chrome-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1797/15/1

@ownclouders
Copy link

💥 Acceptance tests pipeline apiLimitSearches-master-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1798/19/1

@micbar micbar force-pushed the query-string branch 2 times, most recently from e01933c to 70cfdc0 Compare November 23, 2021 16:07
@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-latest-chrome-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1821/17/1

@micbar @JammingBen
make search more greedy
aa986b2 
Signed-off-by: Michael Barz <[email protected]>
@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-latest-chrome-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1832/17/1

@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-master-chrome-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1832/15/1

@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-latest-firefox-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1832/18/1

@ownclouders
Copy link

💥 Acceptance tests pipeline webUISE-master-firefox-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1832/16/1

@ownclouders
Copy link

💥 Acceptance tests pipeline apiSearchElastic-latest-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1833/22/1

@JammingBen
Copy link
Contributor

My findings:

  • SimpleQueryString only supports wildcards as suffix. That means test* will find testfile.txt, but *file* and *file.txt won't work. I replaced it with QueryString to make all wildcards work.
  • When no wildcard given by the user, we append * per default. When searching for lore ips, the backend will get lore* ips*. Uses can set wildcards on their own though.
  • The wildcard syntax that worked previously changed a bit, see https://github.com/owncloud/search_elastic/pull/212/files#diff-58e70a72b6a627b5be574182090add3c05cdc03be59f6fddb98d3f221d9185a9 (foo * => foo*, * baz => *baz, *foo*baz* => *foo* *baz*).
  • Query strings including characters like - don't work anymore.

@ownclouders
Copy link

💥 Acceptance tests pipeline apiSearchElastic-latest-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1835/22/1

@ownclouders
Copy link

💥 Acceptance tests pipeline apiSearchElastic-master-mysql8.0-php7.4-es7.10 failed. The build has been cancelled.

https://drone.owncloud.com/owncloud/search_elastic/1835/21/1

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 1, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

50.0% 50.0% Coverage
0.0% 0.0% Duplication

@JammingBen JammingBen marked this pull request as ready for review December 1, 2021 09:34
@JammingBen JammingBen requested a review from butonic December 1, 2021 09:34
butonic
butonic approved these changes Dec 1, 2021
View reviewed changes
Copy link
Member

@butonic butonic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JammingBen JammingBen merged commit 27501a5 into master Dec 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the query-string branch December 1, 2021 10:20
@jnweiger jnweiger restored the query-string branch December 3, 2021 11:16
@delete-merged-branch delete-merged-branch bot deleted the query-string branch December 3, 2021 11:19
jnweiger added a commit that referenced this pull request Dec 3, 2021
@jnweiger
including #212 in the 2.0.0 release
0162e33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@butonic butonic butonic approved these changes

Assignees

@micbar micbar

Labels
Category:Enhancement Add new functionality Interaction:Blue-Ticket
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@micbar @ownclouders @jnweiger @mmattel @phil-davis @JammingBen @butonic