Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Content for search elastic v2 #4155

Merged
merged 13 commits into from
Dec 4, 2021
Merged

Content for search elastic v2 #4155

merged 13 commits into from
Dec 4, 2021

Conversation

EParzefall
Copy link
Contributor

Adding information on version 2 of the Full Text Search app coming soon. Text is awaiting approval by engineering and product management. Do not merge before the release.
This will fix issue #3996 and issue #3929.

@mmattel
Copy link
Contributor

mmattel commented Oct 23, 2021

I think it would be good to add a table with the supported querystring operators and their usage, see:
owncloud/search_elastic#212 ([Feature] use SimpleQueryString search)
Note, the referenced PR above needs to be finalized and merged, but this is what we have been told that it will come...

@micbar @jnweiger

Copy link
Contributor Author

@EParzefall EParzefall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change for more clarity

Copy link
Contributor

@mmattel mmattel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
we can add the search strings later when the app repo merges the corrspondent PR

Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Text LGTM

@pmaier1
Copy link
Contributor

pmaier1 commented Oct 25, 2021

I think it would be good to add a table with the supported querystring operators and their usage, see:

I think we should keep it simple and link to the Elasticsearch docs that have all this information.

Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks 👍

@mmattel
Copy link
Contributor

mmattel commented Oct 28, 2021

I think it would be good to add a table with the supported querystring operators and their usage, see:

I think we should keep it simple and link to the Elasticsearch docs that have all this information.

I have taken a look on how the referenced ES page presents and I am not convinced to use it. This is the user docs not a docs for persons with in depth knowledge. There is too much information like backend request details ect where users are definitely the wrong audience. Users are looking to "what can I enter to refine my results" and not how a top-level parameters or get is defined.

I propose therefore to create a short table with the simple-query-string syntax which clearly describes the details and limits the info to the neccessary content. Having the link for further details would be ok.

@pmaier1

This comment has been minimized.

@pmaier1
Copy link
Contributor

pmaier1 commented Oct 29, 2021

Wait, please. We have decided against directly using Simple Query String. Instead we build the query strings in the backend and make it easier for the user by not providing so much flexibility. More information to follow soon.

@micbar
Copy link
Contributor

micbar commented Oct 29, 2021

@EParzefall @mmattel We need to change a bit here

I had an approval meeting with Product management today. They were not happy to expose any query language to the end user.

Outcome:
We make the search as greedy as possible. Query string manipulation is not possible in the search field.

@EParzefall
Copy link
Contributor Author

ACK, we'll wait for more info on how the search will actually work.

@pmaier1
Copy link
Contributor

pmaier1 commented Oct 29, 2021

ACK, we'll wait for more info on how the search will actually work.

There's not that much more to say, I guess. We don't expose the query language to the user, so

  • the reference to Elasticsearch docs can be removed (users can't use operators or similar; they just enter their search strings)
  • full text search is now designed to find as many results that contain the search string(s) as possible (we change the internal query language to craft together a query which uses every term as string with leading and trailing wildcards. Example: lorem ipsu will be sent so the server as => *lorem* *ipsu* and will consequently find results that contain one of those strings, partly or fully)
  • full text search considers file names and file content according to this rule

@EParzefall
Copy link
Contributor Author

@micbar @pmaier1 I've removed the simple query sting links and the explanation how to use wildcards.

@phil-davis phil-davis requested a review from pmaier1 November 3, 2021 05:49
Copy link
Contributor

@pmaier1 pmaier1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@EParzefall
Copy link
Contributor Author

Minimal update for now to reflect the changes described in
owncloud/search_elastic#212 (comment)

@mmattel
Copy link
Contributor

mmattel commented Dec 4, 2021

There is no limitation to core (10.9)

Backport to 10.9, 10.8 and 10.7

@mmattel mmattel merged commit c18b7ee into master Dec 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the content-for-search_elastic-v2 branch December 4, 2021 19:27
mmattel pushed a commit that referenced this pull request Dec 4, 2021
mmattel pushed a commit that referenced this pull request Dec 4, 2021
mmattel pushed a commit that referenced this pull request Dec 4, 2021
Things get tricky when you don't remember what the file you're looking for was called and guess work doesn't help. A key word search within text documents is only possible if the Full Text Search app is installed. Contact your admin if you need it and it's not installed. With this app enabled, you can search in files of the most common formats.
Things get tricky when you don't remember what the file you're looking for was called and guess work doesn't help. A key word search within text documents is only possible if the Full Text Search app is installed. Contact your admin if you need it and it's not installed. With this app enabled, you can search within files of the most common formats. Like with the regular search, you can enter only the first part of a string and it matches all occurances of words starting with the search string.

If you are looking for all terms containing a specific string like in the above example "pain", wildcards can be used, e.g. an asterisk: *pain gives you results like braine, Spain and painful. Using a question mark instead of the asterisk limits the preceeding characters to exactly one. In this example, only Spain would show up if you entered the search string "?pain".
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@EParzefall @mmattel why does *pain match braine ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants