make all ocs and webdav API tests pass

[micbar]

⚠️ OBSOLETE ⚠️

see https://etherpad.owncloud.com/p/ocis-api-tests and in https://github.com/orgs/owncloud/projects/181 and https://github.com/orgs/owncloud/projects/182

make all ocs and webdav API tests pass

Guide to work with the testsuite in DEV docs.

https://owncloud.github.io/extensions/ocis_reva/testing/

Tasks

I've grepped the current tests on core master (as of commit 1bec7a397faa37f2edda6af35d2342e433499cf2), came up with the following existing issues:

General

• missing XML body for error responses, should we make them like Sabre DAV ?? => https://github.com/owncloud/ocis-reva/issues/199
  • MKCOL on existing resource
  • PROPFIND on non-existing resource
  • HTTP 401 Unauthorized responses don't contain a body
• missing skeleton folder creation (required by many tests): create test-skeleton folder on user creation ocis-reva#167

File management

• PROPFIND does not return file size in drone
• no OC-Checksum header when downloading file
• OC-Checksum header not checked when uploading file
• versions survive the deletion of a file
• Range Header is not obeyed when downloading a file
• server returns 500 when trying to access a not existing file => https://github.com/owncloud/ocis-reva/issues/163
• renaming a resource does not work
  • fix
  • enable tests
• blacklisted filenames like .htaccess & file.parts can be uploaded
• litmus tests fail:
  • shallow COPY (Depth: 0)
  • recursive COPY (Depth: infinity)
  • MOVE
  • custom properties:
    • PROPFIND does not return custom file properties
    • wrong propstat code for removed properties
    • props failures
  • missing/broken LOCK support
  • cleanup issues
• in core webDav API tests adjust scenarios where w direct WebDAV URL is given
  • fix
  • enable test
• REPORT request not implemented
• cannot get ocs:share-permissions via WebDAV
• deleted files come and go in the trashbin listing
• uploading with old-chunking does not work => deferred / obsoleted by TUS ?
• chunking v2 endpoint => deferred / obsoleted by TUS ?
• creating a folder that already exists returns HTTP 405 Method Not Allowed

Sharing

• sharing fails with error searching recipient
• listing received shares does not work
• share_with field in response after sharing has an extra @localhost attached to the username
• retrieving information about shares via ocs API is not possible
• ocs v2 endpoint still returns ocs v1 status codes
• remote shares API endpoint does not exist
• no way to set default folder for received shares
• multiple values missing in response when sharing file
• create & delete permissions are applied to files when shared
• a share with invalid permissions can be created
• when sharing a folder to a user the default permissions are "1"
• public webdav API endpoint does not exist

Settings

• not possible to set quota for users
• ocs config enpoint only accesible by authorized users
• files_external mounts endpoint does not exist
• various sharing settings cannot be set
• system configuration options missing
• There is no such thing like a "super-user"
• no command equivalent to occ

User Management

• groups endpoint does not exists

Other APIs

• ocs apps endpoint does not exist
• ocs privatedata endpoint does not exist
• Collaborative Tag management
• PROPFIND on the root of the /webdav enpoints returns ERROR 500
• comments API

Security

• ⚠️ users can access each-others data using the new webdav API
• security headers not served when downloading a file
• no way to enforce token auth
• no robots.txt available
• wildcard Access-Control-Allow-Origin
• cannot generate token using /token/generate endpoint
• app passwords are not possible

Todos

• Sort out tagged test pointing at non-existing ticket: https://github.com/owncloud/ocis-webdav/issues/187 => issue not found but mentionned in
• TODO: link all those tickets from the matching product feature tickets

ℹ️ Grep command: grep -rie "issue-ocis" tests/acceptance | sed 's/.*\(ocis-[^\s ]*\).*/\1/' | sort | uniq | sed 's%\(ocis-[^-]*\)-\(\d*\)%- [ ] https://github.com/owncloud/\1/issues/\2%'

[micbar]

EE ticket https://github.com/owncloud/enterprise/issues/3989

[PVince81]

Approach:

• search for all @skipOnOcis tests in the core repo, uncomment and see what tests still fail
• raise tickets based on failing tests if not fixable quickly (or list as checkbox here)

[PVince81]

@PVince81 I moved your list to the top post

[PVince81]

It is likely that enabling tests will take longer than expected. The reason is that one disabled test might hide another failure. For example you might want to reenable a test related to a MOVE operation, but that test also tests checksums which is still not implemented. So you need to replace the issue number with another one after researching which other case is related.

This seems to be the case for example in owncloud/ocis-reva#14: while the main case works, a lot of tests still fail after reenabling, due to various other reasons to investigate. This will increase the estimate for every ticket.

[individual-it]

not all tests marked with an issue are skipped, some are already fixed

[PVince81]

Right, thanks. I forgot to look closely at the @skipOnOcis because somehow my brain connects an issue tag with an implicit skip. Also it seems that I didn't realize that grep for issue tags was pointing me at UI tests instead of API tests.

I'll go through the tickets I touched last week and recheck if the API tests were affected or not.
We might be closer to completion then.

[C0rby]

What do we do about tests which are broken by the tus code?
For example tests/acceptance/features/apiAuthWebDav/webDavPOSTAuth.feature:35.

[individual-it]

@C0rby I cannot find that test in the core repo, that line is in the middle of a scenario. And the whole file is tagged skipOnOcis, so it should not be executed in ocis at all 😕

[C0rby]

Oh you are right, I copied the wrong path... let me change the path above

[PVince81]

if that one has a ticket number, please add the ticket to the checkbox list in the top post.
if there's no ticket, please raise one.

it seems there are already a bunch of sharing related tickets, I didn't look into them yet

[PVince81]

Reorganized the order of tickets in https://etherpad.owncloud.com/p/ocis-api-tests and in https://github.com/orgs/owncloud/projects/181 and https://github.com/orgs/owncloud/projects/182

[PVince81]

closing this, we should use the projects now to track progress