Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No way to set default folder for received shares #1327

Closed
individual-it opened this issue Jan 28, 2020 · 9 comments
Closed

No way to set default folder for received shares #1327

individual-it opened this issue Jan 28, 2020 · 9 comments

Comments

@individual-it
Copy link
Member

No description provided.

@PVince81
Copy link
Contributor

In EOS, this is configurable by directly talking to EOS.
For now we should assume that the shares are always arriving in the "/Shared" folder and are not movable.

  • EOS: Any API tests that cannot adhere to this should be disabled or adjusted.
  • later (raise ticket): API tests for EOS: rewire to talk to EOS to configure default folder (defaults to "/Shared" folder)

@butonic butonic transferred this issue from owncloud/ocis-reva Jan 18, 2021
@refs refs changed the title no way to set default folder for received shares No way to set default folder for received shares Jan 19, 2021
@exalate-issue-sync exalate-issue-sync bot added p3-medium and removed Category:Technical Technical ehancements labels Feb 10, 2021
@settings settings bot removed the p3-medium label Apr 7, 2021
@stale
Copy link

stale bot commented Jun 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Jun 6, 2021
@phil-davis
Copy link
Contributor

For now we should assume that the shares are always arriving in the "/Shared" folder and are not movable.

In reva and OCIS the folder is called /Shares

@stale stale bot removed the Status:Stale label Jun 7, 2021
@stale
Copy link

stale bot commented Aug 6, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 10 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the Status:Stale label Aug 6, 2021
@phil-davis
Copy link
Contributor

Some time ago we sorted out the acceptance test suites so that there are scenarios that test sharing with the share_folder set to Shares. When running against oC10, the share_folder in the config gets explicitly set to Shares. When running against oCIS, that is already the default, and the step that "sets the config" does nothing.

There is another set of sharing scenarios that has the oC10 default - share_folder is not set, and received shares appear in the root of the receiving user's file system. Those scenarios are only run with CI against oC10. They are not applicable to oCIS.

At some time, someone will need to decide if the hard-coded Shares folder in oCIS should have a configurable name, or...

@stale stale bot removed the Status:Stale label Aug 6, 2021
@pmaier1
Copy link
Contributor

pmaier1 commented Aug 11, 2021

In reva and OCIS the folder is called /Shares

Exactly. And there are no plans for now to make this configurable. Please adjust tests and remove from expected failures.

@phil-davis
Copy link
Contributor

We have already adjusted the test suite so that all the sharing tests are done with a Shares folder for oCIS CI.
There are other tests that check the default oC10 sharing behavior - the received shares appear in the root of the receiver's file system. Those are all tagged notToImplementOnOcis

There should not be any tests in expected-failures related to this. @dpakach please get someone to double-check.

@pmaier1
Copy link
Contributor

pmaier1 commented Aug 11, 2021

@individual-it
Copy link
Member Author

tests are marked @notToImplementOnOCIS in owncloud/core#39117 so closing this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants