This repository has been archived by the owner on Jan 3, 2024. It is now read-only.
Refactor and document OcStar(Toggle) #525
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 28, 2019
LukasHirt
suggested changes
Nov 4, 2019
marcus-herrmann
force-pushed
the
feature/a11y-documentation/star
branch
from
d3b150e to
01472f2
Compare
LukasHirt
approved these changes
Nov 4, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this PR
role="switch"conveying its state with `aria-checked="true|false"OcStarToggle as a replacement for OcSwitch
In ODS OcSwitch is an image that reacts to a toggle button, but is not the toggle button itself. OcStarToggle matches Phoenix's current implementation of the star being the interactive control (alas, not a button. But this is what this OR is for).
Relation to issues
Discussion started in this PR: #481 (comment)
Background on toggle/switch buttons:
Article by Heydon Pickering, longread