Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accessibility Issues in FileList component #2332

Closed
marcus-herrmann opened this issue Oct 28, 2019 · 0 comments · Fixed by #2333
Closed

Accessibility Issues in FileList component #2332

marcus-herrmann opened this issue Oct 28, 2019 · 0 comments · Fixed by #2333

Comments

@marcus-herrmann
Copy link
Contributor

Steps to reproduce

  1. Use Phoenix with assistive technology, such as: Screen Reader

Expected behaviour

The user should know of the existence of every interactive element and their functionsthe contents of every table column by label table headers.

Actual behaviour

Most of the checkboxes are unlabeled, the files or folder controls are semantically the wrong element (covered in #2317), some table headers appear empty:

Screenshot of Phoenix's interface, with added numbers, see below

  1. This table header item/column header conains just an unlabel checkbox, therefore no text information that could serve as label
  2. This table header item/column header is completely empty
  3. This checkbox is not labelled
  4. This star image is semantically speaking not a control but a clickable div (covered in ODS PR Refactor and document OcStar(Toggle) owncloud-design-system#525)
  5. This File/Folder label is also just a clickable span (covered in Middle click to file/folder open in new tab #2317)

(The rest of the issue template is irrelevant to the kind of this issue)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant