Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Bugfix: Drag & Drop doesn't select files correctly #1562

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Bugfix: Drag & Drop doesn't select files correctly #1562

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2e2100d
bugfix selected files drag drop
lookacat Aug 3, 2021
7b9675f
updated pull request
lookacat Aug 3, 2021
b65cb5d
Update changelog/unreleased/bugfix-selected-files-drag-drop
lookacat Aug 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelog/unreleased/bugfix-selected-files-drag-drop
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
Bugfix: Drag & Drop doesn't select files correctly

Due to refactoring there was a case where selecting files when dragging didn't work right. This has been addressed and fixed now.

https://github.com/owncloud/owncloud-design-system/issues/1560
https://github.com/owncloud/owncloud-design-system/pull/1562
2 changes: 1 addition & 1 deletion src/components/table/OcTableFiles.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -382,7 +382,7 @@ export default {
methods: {
fileDragged(file) {
const selectedResourceInResources = this.selectedResources.some(e => e.id === file.id)
if (selectedResourceInResources) {
if (!selectedResourceInResources) {
this.selectedResources.push(file)
}
this.$emit("select", this.selectedResources)
Expand Down