Skip to content
This repository has been archived by the owner on Jan 3, 2024. It is now read-only.

Bugfix: Drag & Drop doesn't select files correctly #1562

Merged
merged 3 commits into from
Aug 4, 2021
Merged

Bugfix: Drag & Drop doesn't select files correctly #1562

merged 3 commits into from
Aug 4, 2021

Conversation

lookacat
Copy link
Contributor

@lookacat lookacat commented Aug 3, 2021

Description

See #1560

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation added/updated

pascalwengerter
pascalwengerter reviewed Aug 3, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes LGTM, wording in the changelog item should give more context 😇 sorry for being naggy!

changelog/unreleased/bugfix-selected-files-drag-drop Outdated Show resolved Hide resolved
@lookacat
Copy link
Contributor Author

lookacat commented Aug 3, 2021

@pascalwengerter yes you are right, was just trying to fix it as fast as possible

@sonarcloud
Copy link

sonarcloud bot commented Aug 3, 2021

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

pascalwengerter
pascalwengerter approved these changes Aug 4, 2021
View reviewed changes
Copy link
Contributor

@pascalwengerter pascalwengerter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd love to have tests for this but should be good for now

@lookacat lookacat merged commit ab211aa into master Aug 4, 2021
@delete-merged-branch delete-merged-branch bot deleted the bugfix-selected-file-drag-drop branch August 4, 2021 14:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pascalwengerter pascalwengerter pascalwengerter approved these changes

@kulmann kulmann Awaiting requested review from kulmann

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lookacat @pascalwengerter