Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add db value store #167

Merged
merged 1 commit into from
Jul 22, 2021
Merged

Add db value store #167

merged 1 commit into from
Jul 22, 2021

Conversation

hurradieweltgehtunter
Copy link
Contributor

@hurradieweltgehtunter hurradieweltgehtunter commented Jul 13, 2021 •
edited
Loading

Description

This PR adds the possibility to load config values from DB for clustered setups.

Motivation and Context

Storing values in config.php can lead to problems in clustered setups (stateful instances). Storing the config values in the DB solves this problem.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added

Open tasks:

  • Documentation ticket raised:

@hurradieweltgehtunter hurradieweltgehtunter self-assigned this Jul 13, 2021
@CLAassistant
Copy link

CLAassistant commented Jul 13, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

DeepDiver1975
DeepDiver1975 reviewed Jul 13, 2021
View reviewed changes
lib/Client.php Outdated Show resolved Hide resolved
@hurradieweltgehtunter hurradieweltgehtunter changed the title [WiP] Add db value store Add db value store Jul 21, 2021
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@hurradieweltgehtunter hurradieweltgehtunter mentioned this pull request Jul 21, 2021
Closed
45 tasks
@DeepDiver1975 DeepDiver1975 merged commit fd9ae9e into master Jul 22, 2021
@delete-merged-branch delete-merged-branch bot deleted the add-db-value-store branch July 22, 2021 09:09
@jnweiger jnweiger mentioned this pull request Sep 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DeepDiver1975 DeepDiver1975 DeepDiver1975 approved these changes

Assignees

@hurradieweltgehtunter hurradieweltgehtunter

Labels
3 - To Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hurradieweltgehtunter @CLAassistant @DeepDiver1975