Release openidconnect 2.1.0

[hurradieweltgehtunter]

Reason

#148 [Security] Bump phpseclib/phpseclib from 2.0.29 to 2.0.31
#150 [Enhancement] AutoProvisioning based on a Provisioning Claim
#151 [Enhancement] Autoprovisionining based on claim
#155 [Bugfix] Use random_bytes for uid and password generation
#167 [Enhancement] Add db as additional settings storage backend

Release is required (mainly because of #167 ) for use in ownCloud Online.

Product approval

• Verify transifex commits are in master: If a folder https://github.com/owncloud//tree/master/l10n exists, then https://drone.owncloud.com/owncloud/ should receive nightly '[tx] updated from transifex` ...
• Ping pmaier to check info.xml description and screenshot
• Get approval on translations from pmaier - send the date of the last tx commit from drone to Patrick

QA

• Create QA Milestone and set the description to $version
• Move tickets from milestone development to qa (testplan and tickets mentioned in release ticket)
• Create release branch with the format "release-$version"
• Create "$version Testplan" -> [QA] 2.1.0 Testplan #179
• copy new/reopened issues from the previous release ticket as 'Issues to review' below.
• check if Non-normal Release Process applies, and adapt this checklist.

Documentation

• Changes in the docs needed? If so create issue in owncloud/docs.

Marketing

• Ping @owncloud/marketing
• Update https://confluence.owncloud.com/display/PROD/Upcoming+Releases
• Request a screenshot if the app is new or changed fundamentally

Build

All actions to be done on the release branch from here:

• Bump version in info.xml (no version suffix)
• Bump "sonar.projectVersion=" in sonar-project.properties (no version suffix)
• Check php version dependency in info.xml
• Check minimum ownCloud version dependency in info.xml
• Change CHANGELOG.md 'Unreleased' to '$version' (today's date)

Beta/RC

• Ping product owner to create github tag for v${version}-rc1 on release branch (see https://confluence.owncloud.com/display/EN/Product+Owners+List)
• Build and sign RC tarball from github tag v${version}-rc1 (see handbook for how to build)
• Upload as Github release using changelog entries
• Manual testing (changelog, regression, explorative):
  • If this is an enterprise app: Enabling the app must start the grace period
  • If this is the initial release of an app: Check that the minimum version constraint resolves correctly
  • Changelog testing
  • Test and document in testplan => Final "Go" from QA (set 'QA-ready' label) => else do another RC after fixing issues in the "release-$version" branch
    • server + web ui + desktop regression tests
    • android regression tests
    • ios regression tests

Final

• Check that no documentation issues are pending
• Rename last RC tarball to final
• Create github tag for final v${version} on release branch
• Upload as Github release using changelog entries
• Ping #marketing channel to coordinate publishing

Publishing

• Upload tarball to marketplace (see handbook in confluence for details)
• Publish tarball for customers - old 10, old 10.0 and new portal (see handbook for details)
• Send mail to release-coordination with link to this ticket and to the changelog
• Copy email to rocket chat #updates channel

Post-release

• Add a new 'Unreleased' section in CHANGELOG.md (and also update links at the bottom!)
• Create PR to merge changes back to the master branch with description "Closes #XYZ" with the release ticket number
• Rename QA milestone to $version and close the milestone
• Update https://confluence.owncloud.com/display/PROD/Upcoming+Releases
• Ensure release template is up to date
• Ensure the testplan template (community or enterprise) is up to date
• Close the testplan issue

[jnweiger]

Testplan draft: #132
Please ping me for additions, I'll make a nice testplan from that.

I assume this will be a slow release, multiple new setups are needed here.

[hurradieweltgehtunter]

@jnweiger Testplan needs the following additions regarding #167
For other PR's we need to ask PR creators
@IljaN @T0mWz @DeepDiver1975 could you please give information about PR's #148 #150 #151 #155 ?

Add no settings at all

• Enable app
• Test login

Expected behaviour

App fails the same way as previous release

Add no settings to DB

• Add valid settings to config.php (default way, not altered)
• Remove any existing config settings in DB
• Enable app
• Test login

Expected behaviour

Login should work

Add invalid settings to DB

• Add valid settings to config.php (default way, not altered)
• Add settings to DB as stated in Readme (https://github.com/owncloud/openidconnect#settings-in-database) but use a malformed JSON string
• Enable app
• Test login

Expected behaviour

• Login should work
• ownCloud.log should contain an error message, see

  openidconnect/lib/Client.php

  Line 102 in fd9ae9e

  'Loaded config from DB is not valid (malformed JSON); JSON Last Error: ' . json_last_error(),

Add valid settings to DB

• Add settings to DB as stated in Readme (https://github.com/owncloud/openidconnect#settings-in-database)
• Enable app
• Test login

Expected behaviour

Login should work

[jnweiger]

@hurradieweltgehtunter can you provide test instances fro the above issues?

[hurradieweltgehtunter]

I don't have access to set up public instances, Sorry.

[hurradieweltgehtunter]

Is this going forward? Anything I can do to speed this up?

[michaelstingl]

Is this going forward? Anything I can do to speed this up?

No progress. Blocked by other priorities and vacations.

[jnweiger]

@IljaN @T0mWz @DeepDiver1975 could you please give information about PR's #148 #150 #151 #155 ?

Do we have any details about these issues?

[DeepDiver1975]

#148

library update

#150 #151

customer feature for surf

#155

library update

[DeepDiver1975]

Also an important change in this release which needs to go out - #130

[T0mWz]

@jnweiger what information is required for #150 #151 ?
had described this little bit in issue #149, but maybe it's to short or more info required. Please let me know, you can also find me on Rocket Chat. 😃

[jnweiger]

RC1 created: https://github.com/owncloud/openidconnect/releases/download/v2.1.0-rc1/openidconnect-2.1.0-rc1.tar.gz

[DeepDiver1975]

Most recent tests with openidconnect app (git master) have shown that PKCE is not properly working.
Upstream fix is pending at the moment: jumbojett/OpenID-Connect-PHP#273

Affected IdPs: any who supports PKCE or enforces it.

[jnweiger]

Issues opened while testing

• [QA] openidconnect no longer works with the kopano IDP #181
• https://github.com/owncloud/openidconnect/issues/182 -> [QA] token renewal after 10 min fails client#9056
• empty json array in db leads to error, although a valid fallback is present in config.php #191
• Client user is locked in oidc workflow after oidc was disabled at the server client#9205

[jnweiger]

RC2 built. It includes the fix for #181

[jnweiger]

RC2 passed changelog regression tests.