Fixes #86 and #106 - properly handle token expiry in the sabre dav au… #108
Conversation
DeepDiver1975
force-pushed
the
bugfix/86+106
branch
from
d255f83 to
20a004f
Compare
Codecov Report
@@ Coverage Diff @@
## master #108 +/- ##
============================================
+ Coverage 93.33% 93.38% +0.04%
- Complexity 121 122 +1
============================================
Files 10 10
Lines 420 423 +3
============================================
+ Hits 392 395 +3
Misses 28 28
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
I would expect code that checks for expired token and then do some actions to refresh it.
I don't understand what is going on here. some comments would be helpful.
I have an easy reproducer to test the 10min timeout, so whatever it does, I can easily veryfy, if it is successful afterwards :-)
| $this->session->close(); | ||
| return $this->principalPrefix . $userId; | ||
| } catch (\Exception $ex) { | ||
| $this->session->close(); |
There was a problem hiding this comment.
I would expect code that checks for expired token and then do some actions to refresh it.
I don't understand what is going on here. some comments would be helpful.
I have an easy reproducer to test the 10min timeout, so whatever it does, I can easily veryfy, if it is successful afterwards :-)
There was a problem hiding this comment.
I would expect code that checks for expired token and then do some actions to refresh it.
We as the reply party cannot refresh the token - this is upon the clients to take care.
(The server has no refresh token)
…th backend for openidconnect
Description
token expiry shall not lead to 500 but a proper 401
Related Issue
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
Open tasks: