Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QA] [OIDC] Token refresh fails #106

Closed
jnweiger opened this issue Oct 8, 2020 · 9 comments · Fixed by #108
Closed

[QA] [OIDC] Token refresh fails #106

jnweiger opened this issue Oct 8, 2020 · 9 comments · Fixed by #108
Assignees
@DeepDiver1975

Comments

@jnweiger
Copy link
Contributor

jnweiger commented Oct 8, 2020

Tested with server 10.5 + openidconnect 1.0.0RC4 for #66 + desktop client testpilotcloud version 2.7.0daily20201004 (build 2209)

  • connect via oidc
  • wait a few minutes
  • add a local folder, upload starts
  • wait for an explosion:
    image

Despite the above error, the upload went fine:
image

Expected behaviour: The client does a refresh automatically, when the token expires.
Workaround: Client -> Account -> log out / log in fixes the situation. But requires a confirmation on the IDP page.

Client log:
20201008_0929_owncloud.log.0.zip

server log:
jw-openidconnect-1-0-0rc4-test-vbw0q.log.zip

@TheOneRing Please transfer to owncloud/openidconnect, if you think this is more a server bug.
@TheOneRing
Copy link
Contributor

@DeepDiver1975 shouldn't we get a 401 instead of a 500?

@DeepDiver1975
Copy link
Member

500 is always bad .... you should never get this ....

@DeepDiver1975
Copy link
Member

plz post the owncloud server log (the docker compose stdout does not help - sorry)

@TheOneRing
Copy link
Contributor

Can we transfer the issue?

@DeepDiver1975 DeepDiver1975 transferred this issue from owncloud/client Oct 8, 2020
@DeepDiver1975 DeepDiver1975 self-assigned this Oct 8, 2020
@DeepDiver1975
Copy link
Member

plz post the owncloud server log (the docker compose stdout does not help - sorry)

@jnweiger

@jnweiger
Copy link
Contributor Author

jnweiger commented Oct 8, 2020

Hmpf. I use the official docker-compose logs command. Okay. It is different from the expected owncloud log -- bad.

@jnweiger
Copy link
Contributor Author

jnweiger commented Oct 8, 2020

owncloud.log.zip

@TheOneRing TheOneRing mentioned this issue Oct 9, 2020
Closed
@DeepDiver1975
Copy link
Member

Nothing of interest in the logs. Maybe in the apache error log?

But it looks like this is the same issue as this one #86

@DeepDiver1975 DeepDiver1975 mentioned this issue Oct 14, 2020
Merged
10 tasks
DeepDiver1975 added a commit that referenced this issue Oct 14, 2020
@DeepDiver1975
xFixes #86 and #106 - properly handle token expiry in the sabre dav a…
20a004f 
…uth backend for openidconnect
micbar added a commit that referenced this issue Oct 15, 2020
@micbar
Merge pull request #108 from owncloud/bugfix/86+106
55fd4f7 
Fixes #86 and #106 - properly handle token expiry in the sabre dav au…
@jnweiger
Copy link
Contributor Author

created https://github.com/owncloud/openidconnect/releases/tag/v1.0.0RC5 with this fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DeepDiver1975 DeepDiver1975

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixes #86 and #106 - properly handle token expiry in the sabre dav au… owncloud/openidconnect
3 participants
@TheOneRing @DeepDiver1975 @jnweiger