Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] merge test-acceptance-api and test-acceptance-from-core-api commands #9914

Merged
merged 1 commit into from
Sep 5, 2024
Merged

[tests-only][full-ci] merge test-acceptance-api and test-acceptance-from-core-api commands #9914

merged 1 commit into from
Sep 5, 2024

Conversation

nirajacharya2
Copy link
Contributor

@nirajacharya2 nirajacharya2 commented Aug 26, 2024 •
edited by saw-jan
Loading

Description

This PR

  • removes command test-acceptance-from-core-api
  • merge behat configs behat.yml and behat-core.yml
  • uses command test-acceptance-api for running all tests

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • test case 1:
  • test case 2:
  • ...

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Aug 26, 2024
@nirajacharya2 nirajacharya2 force-pushed the refactor-behat-command branch 18 times, most recently from 89a36d1 to 194e3b8 Compare August 29, 2024 03:29
@nirajacharya2 nirajacharya2 marked this pull request as ready for review August 29, 2024 03:32
@nirajacharya2 nirajacharya2 force-pushed the refactor-behat-command branch 3 times, most recently from 7c69338 to 955317b Compare August 29, 2024 09:28
@saw-jan saw-jan requested review from ScharfViktor and ishabaral and removed request for phil-davis, individual-it, micbar and wkloucek August 29, 2024 10:59
saw-jan
saw-jan reviewed Aug 29, 2024
View reviewed changes
Makefile Show resolved Hide resolved
@nirajacharya2 nirajacharya2 force-pushed the refactor-behat-command branch from 955317b to d61d2bc Compare August 29, 2024 11:03
saw-jan
saw-jan approved these changes Aug 29, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

saw-jan
saw-jan requested changes Aug 29, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see remnants of test-acceptance-from-core-api in tests/acceptance/docker. Please, fix them as well.
Also, the docker compose setup should work.

And do the ocis bump in reva

@saw-jan saw-jan changed the title [tests-only][full-ci] removing test-acceptance-from-core-api command [tests-only][full-ci] merge test-acceptance-api and test-acceptance-from-core-api commands Sep 2, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Sep 2, 2024
Merged
@nirajacharya2
removing test-acceptance-from-core-api and merging core and api beh…
415a4b5 
…at config files to use single command to run api tests
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Sep 3, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

phil-davis
phil-davis approved these changes Sep 3, 2024
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems OK now, if the reva run also works fairly easily with this test code refactoring.

saw-jan
saw-jan reviewed Sep 3, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, update the docs as well

@saw-jan saw-jan mentioned this pull request Sep 4, 2024
Merged
9 tasks
saw-jan
saw-jan approved these changes Sep 4, 2024
View reviewed changes
Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
@nirajacharya2 Please, follow up the docs changes

@nirajacharya2 nirajacharya2 merged commit d26829d into master Sep 5, 2024
4 checks passed
ownclouders pushed a commit that referenced this pull request Sep 5, 2024
@nirajacharya2
Merge pull request #9914 from owncloud/refactor-behat-command
0411d38 
[tests-only][full-ci] merge `test-acceptance-api` and `test-acceptance-from-core-api` commands
@nirajacharya2 nirajacharya2 deleted the refactor-behat-command branch September 5, 2024 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prashant-gurung899 prashant-gurung899 prashant-gurung899 left review comments

@saw-jan saw-jan saw-jan approved these changes

@phil-davis phil-davis phil-davis approved these changes

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@ScharfViktor ScharfViktor Awaiting requested review from ScharfViktor

@ishabaral ishabaral Awaiting requested review from ishabaral

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[QA] single command to run all API/CLI tests
4 participants
@nirajacharya2 @phil-davis @saw-jan @prashant-gurung899