Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] cleanup ocis/oc10 parallel-deployment tests #9900

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

prashant-gurung899
Copy link
Contributor

@prashant-gurung899 prashant-gurung899 commented Aug 23, 2024

Description

This PR cleans up tests and files related to ocis/oc10 parallel-deployment.

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

Copy link
Member

@saw-jan saw-jan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. let's wait for @ScharfViktor .
@prashant-gurung899 Please, mark issue #9870 as fixed in this PR (that should automatically close the issue)

@prashant-gurung899
Copy link
Contributor Author

LGTM. let's wait for @ScharfViktor . @prashant-gurung899 Please, mark issue #9870 as fixed in this PR (that should automatically close the issue)

Sure. 👍

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@saw-jan
Copy link
Member

saw-jan commented Sep 4, 2024

@prashant-gurung899 Could you also check: #9914 (comment)

@prashant-gurung899 prashant-gurung899 force-pushed the cleanup-parallel-deployment branch 2 times, most recently from 3275052 to edaee88 Compare September 5, 2024 09:21
Copy link
Contributor

@ScharfViktor ScharfViktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of that 👍

Just one nitpick: I'd delete parallel-deployment from testing doc https://owncloud.dev/ocis/development/testing/#running-tests-for-parallel-deployment

Signed-off-by: prashant-gurung899 <[email protected]>
@prashant-gurung899 prashant-gurung899 force-pushed the cleanup-parallel-deployment branch from edaee88 to 2506502 Compare September 10, 2024 06:17
Copy link

@saw-jan saw-jan merged commit 2b8ba4f into master Sep 10, 2024
4 checks passed
@saw-jan saw-jan deleted the cleanup-parallel-deployment branch September 10, 2024 08:53
ownclouders pushed a commit that referenced this pull request Sep 10, 2024
[tests-only][full-ci] cleanup ocis/oc10 parallel-deployment tests
ownclouders pushed a commit that referenced this pull request Sep 11, 2024
[tests-only][full-ci] cleanup ocis/oc10 parallel-deployment tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[QA][API test] cleanup tests related to ocis/oc10 parallel-deployment
4 participants