use key to get specific trash item

[butonic]

The activitylog and clientlog services now only fetch the specific trash item instead of getting all items in trash and filtering them on their side. This reduces the load on the storage users service because it no longer has to assemble a full trash listing.

related #9866

[butonic]

the test fails because decomposedfs is implemented in a way that when the resource identified by the key is a folder it will list the children of that folder. When it is a file it will return only that file:

	nodeType := fs.lu.TypeFromPath(ctx, originalPath)
	if nodeType != provider.ResourceType_RESOURCE_TYPE_CONTAINER {
		// this is the case when we want to directly list a file in the trashbin
		blobsize, err := strconv.ParseInt(string(attrs[prefixes.BlobsizeAttr]), 10, 64)
		if err != nil {
			return items, err
		}
		item := &provider.RecycleItem{
			Type:         nodeType,
			Size:         uint64(blobsize),
			Key:          filepath.Join(key, relativePath),
			DeletionTime: deletionTime,
			Ref: &provider.Reference{
				Path: filepath.Join(origin, relativePath),
			},
		}
		items = append(items, item)
		return items, err
	}

        // ... goes on to list all children. the directory is not added

I need to doube check how the key and path are used ...

👀

🤔

😵

ok so no storage driver implementation, other than decomposedfs, looks at the key. only decomposedfs has some logic that would allow navigating the trash ...

so the storageprovider can actually pass

1. key="" and relativePath="" to the ListRecycle implementations when no key was present.
2. key=key and relativePath="" to get specific trash item
3. key=key and relativePath="/" to get the children of a folder or
4. key=key and relativePath=relativePathStartingWithASlash to get the children of a subfolder

So there is a difference in sending a key with or without ending in a /.

[butonic]

implemented the above in cs3org/reva#4818

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud