allow listing directory trash items by key #4818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2403905
reviewed
Aug 21, 2024
butonic
force-pushed
the
trash-listing-bykey-fixes
branch
2 times, most recently
from
68e00dc to
6dec94e
Compare
2403905
approved these changes
Aug 21, 2024
butonic
force-pushed
the
trash-listing-bykey-fixes
branch
6 times, most recently
from
6100655 to
6c4bbb5
Compare
Signed-off-by: Jörn Friedrich Dreyer <[email protected]>
butonic
force-pushed
the
trash-listing-bykey-fixes
branch
from
6c4bbb5 to
fc52c0c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The storageprovider now passes on the key without inventing a
/as the relative path when it was not present at the end of the key. This allows differentiating requests that want to get the trash item of a folder itself (where the relative path is empty) or listing the children of a folder in the trash (where the relative path at least starts with a/).We also fixed the
/dav/spacesendpoint to not invent a/at the end of URLs to allow clients to actually make these different requests.As a byproduct we now return the size of trashed items.
required by owncloud/ocis#9879