Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cache ocis build artifact for tests #976

Closed
wants to merge 5 commits into from

Conversation

wkloucek
Copy link
Contributor

Reopen of #961, since CI was stuck on that PR.

oCIS binary is build once and then provided for all tests (acceptance test, ui tests, but not for go linting, ...).

Diffs between master and branch look good for following tests:

  • drone starlark
  • drone starlark --build.event cron
  • drone starlark --build.event pull
  • drone starlark --build.event pull --build.message "[docs-only.]"
  • drone starlark --build.message "[docs-only.]"

@update-docs
Copy link

update-docs bot commented Nov 27, 2020

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@wkloucek wkloucek force-pushed the cache_ocis_build_artifact_for_tests branch from 8ee0de7 to e6fd4ec Compare November 28, 2020 10:50
@wkloucek wkloucek closed this Nov 28, 2020
@wkloucek wkloucek deleted the cache_ocis_build_artifact_for_tests branch November 28, 2020 10:59
@wkloucek
Copy link
Contributor Author

CI seemed stuck - but the definition hat a very long pipeline name. This led to a silent drone fail.

@phil-davis
Copy link
Contributor

There is a 50-character limit on pipeline names.
https://github.com/owncloud/core/blob/master/.drone.star has some basic code that checks for this:

	maxLength = 50
	nameLength = len(name)
	if nameLength > maxLength:
		print("Error: generated phpunit stage name of length", nameLength, "is not supported. The maximum length is " + str(maxLength) + ".", name)
		errorFound = True

It was useful back in the days when we generated .drone.yml locally and committed it. But I don't know how an "error print" like that is going to be able to be visible to the user when it happens on the server.

Sadly the server starlark extension is not great at telling what went wrong.

@wkloucek
Copy link
Contributor Author

I think this will still be useful since it would have saved me a lot of time. When developing on the .drone.star I regularly convert it to yaml... This also was fine, but the server just refused to run the resulting yaml. I will add a warning in #973

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants