Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only] refactor drone definition #973

Merged
merged 1 commit into from
Dec 14, 2020
Merged

[tests-only] refactor drone definition #973

merged 1 commit into from
Dec 14, 2020

Conversation

wkloucek
Copy link
Contributor

@wkloucek wkloucek commented Nov 27, 2020 •
edited
Loading

Things changed:

  • declare volumes once and use them like "named volumes"
  • sanity check: issue warning if pipeline or step name exceeds 50 characters
  • sanity check: issue warning if volume is declared in step but not in pipeline
  • sanity check: issue warning if depends_on is referencing non existing pipeline
  • helper: print count of all used docker images and versions
  • add helper for depends_on mangement: "pipelineDependsOn" and "pipelinesDependsOn"

@wkloucek
Copy link
Contributor Author

Also consider this: https://github.com/owncloud/core/blob/621a09501d9afd81afcc5f62765b9858ed5a7cce/.drone.star#L1144

@wkloucek wkloucek mentioned this pull request Nov 28, 2020
Closed
@wkloucek wkloucek force-pushed the refactor_drone_definition branch 3 times, most recently from 3a6c96b to 8dcb9da Compare December 7, 2020 08:25
@wkloucek wkloucek marked this pull request as ready for review December 7, 2020 08:44
@wkloucek wkloucek force-pushed the refactor_drone_definition branch from 8dcb9da to 3741b4c Compare December 14, 2020 10:53
phil-davis
phil-davis reviewed Dec 14, 2020
View reviewed changes
Copy link
Contributor

@phil-davis phil-davis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I only found one strange break of text of the word "normally"!
Was there a reason for that?

.drone.star Show resolved Hide resolved
.drone.star Show resolved Hide resolved
.drone.star Outdated Show resolved Hide resolved
@phil-davis phil-davis changed the title refactor drone definition [tests-only] refactor drone definition Dec 14, 2020
@owncloud owncloud deleted a comment from update-docs bot Dec 14, 2020
@phil-davis phil-davis force-pushed the refactor_drone_definition branch from 3741b4c to 8b73f7b Compare December 14, 2020 12:54
@phil-davis phil-davis self-requested a review December 14, 2020 12:54
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@phil-davis phil-davis merged commit 0722d45 into master Dec 14, 2020
@delete-merged-branch delete-merged-branch bot deleted the refactor_drone_definition branch December 14, 2020 14:45
ownclouders pushed a commit that referenced this pull request Dec 14, 2020
@phil-davis
commit 0722d45
7c73e38 
Merge: ddfe2ba 8b73f7b
Author: Phil Davis <[email protected]>
Date:   Mon Dec 14 20:30:24 2020 +0545

    Merge pull request #973 from owncloud/refactor_drone_definition

    [tests-only] refactor drone definition
@wkloucek wkloucek mentioned this pull request Dec 16, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-davis phil-davis phil-davis approved these changes

@individual-it individual-it Awaiting requested review from individual-it individual-it is a code owner

@micbar micbar Awaiting requested review from micbar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wkloucek @phil-davis