Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tests-only][full-ci] split SharingNG link share test suite #9509

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

anon-pradip
Copy link
Contributor

Description

  • Added test coverage for splitting share link tests for apiSharingNgLinkShare/linksShare.feature
  • Separated the scenarios related to update, remove and create share link in their respective files.

Related Issue

Motivation and Context

How Has This Been Tested?

  • Locally
  • CI

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@anon-pradip anon-pradip self-assigned this Jul 2, 2024
@anon-pradip anon-pradip force-pushed the test/split-share-link-tests branch 3 times, most recently from 625171e to a76b556 Compare July 3, 2024 07:32
@saw-jan
Copy link
Member

saw-jan commented Jul 3, 2024

> Line 256: Link is not correct for apiSharingNgLinkShare/createLinkShare.feature:1656
  + Actual link   : https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSharingNgLinkShare/createLinkShare.feature#1656
  - Expected link : https://github.com/owncloud/ocis/blob/master/tests/acceptance/features/apiSharingNgLinkShare/createLinkShare.feature#L1656

Errors were found in the expected failures file - see the messages above!

Copy link
Member

@SagarGi SagarGi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 (very much on point)

@anon-pradip anon-pradip force-pushed the test/split-share-link-tests branch from 63a8a54 to 5837150 Compare July 4, 2024 07:02
Copy link
Contributor

@amrita-shrestha amrita-shrestha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@anon-pradip anon-pradip force-pushed the test/split-share-link-tests branch from 5837150 to 7f2660f Compare July 8, 2024 03:53
@saw-jan saw-jan changed the title [tests-only][full-ci] test: split share link tests for apiSharingNgLinkShare/linksShare.feature [tests-only][full-ci] split SharingNG link share test suite Jul 8, 2024
Copy link

sonarqubecloud bot commented Jul 8, 2024

@SagarGi SagarGi merged commit ffb27de into master Jul 8, 2024
3 checks passed
ownclouders pushed a commit that referenced this pull request Jul 8, 2024
[tests-only][full-ci] split SharingNG link share test suite
@amrita-shrestha amrita-shrestha deleted the test/split-share-link-tests branch September 12, 2024 04:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants