[QA][Sharing NG] ApiTest: Extend share link coverage

[amrita-shrestha]

Describe the bug

Under this issue #7968 test coverage for share link of personal and share drive has been covered.

TO-DO

• check other missing coverage and add
  • [tests-only][full-ci] adding test for updating share link of a folder in personal space using permission endpoint #9285
• All Space Members should be able to create internal links
  • [ocis] All Space Members should be able to create internal links #8960 (will be fixed by Always allow users to create internal links, add public share tests cs3org/reva#4633)
  • API test PR @nirajacharya2 [tests-only][full-ci] adding test for creating internal link share by the member of a project drive #9434
• Create share link (project drive)
  • project resources [tests-only][full-ci] Add tests for create link on project spaces resources #9044
  • using drives.permissions endpoint for all drive @S-Panta [tests-only][full-ci] adding test for creating link space share via permission endpoint #9250
• update/set password on project drive
  • project resources [tests-only][full-ci] Add tests for create link on project spaces resources #9044
  • project drive [tests-only][full-ci] adding test for updating share link of a project space using permission endpoint #9251
• update share link
  • project @nirajacharya2
    • space itself [tests-only][full-ci] adding test for updating share link of a project space using permission endpoint #9251
    • file @prashant-gurung899 [tests-only][full-CI] adding test for updating share link of a resource in project space. #9297
    • folder @prashant-gurung899 [tests-only][full-ci]Add test for updating link of a folder in project-space using permissions endpoint. #9300
  • personal

    ocis/tests/acceptance/features/apiSharingNgLinkShare/linkShare.feature

    Line 2305 in b870c0d

    Scenario Outline: try to create a link share of a Personal and Shares drives using permissions endpoint

• remove share link @nirajacharya2
  • project space
    • [tests-only][full-ci] adding test for removing link share of a project space using permissions endpoint #9246
    • [tests-only][full-ci] adding test for deleting/removing share link of a project space using permission endpoint #9233
  • personal

    ocis/tests/acceptance/features/apiSharingNgLinkShare/linkShare.feature

    Line 2305 in b870c0d

    Scenario Outline: try to create a link share of a Personal and Shares drives using permissions endpoint

• quicklink share: {"type":"internal","@libre.graph.quickLink":false,"password":"","displayName":"Link"}:
  • Permissions (Personal)
    • file/folder in personal [tests-only][full-ci] added tests for creating quickLink using permissions endpoint #9362
  • Permissions (Project)
    • drive share [tests-only][full-ci] added tests for creating quickLink using permissions endpoint #9362
    • file/folder [tests-only][full-ci] added tests for creating quickLink using permissions endpoint #9362
  • Root (drive share) @prashant-gurung899 [tests-only][full-ci] add tests to create quick link of space drive using root endpoint #9375

refactor step

• [full-ci][tests-only] renaming the scenario in linkShare to be more consistent #9407
• [tests-only][full-ci]extend list permission tests coverage for root endpoint #9125 (comment)
  • [full-ci][tests-only] renaming step for sending invitation with all allowed permission #9410

CI Refactoring

• remove link-related test from tests/acceptance/features/apiSharingNg/removeAccessToDriveItem.feature and add to another suite with a suitable name. if CI time got extended @anon-pradip [tests-only][full-ci] split apiSharingNg test features to different suites #9523
• Currently, all share link-related tests exist in the same file apiSharingNg/linkShare.feature. If needed split them in createShareLink.feature, removeShareLink.feature, updateShareLinkand so on. @anon-pradip [tests-only][full-ci] split SharingNG link share test suite #9509

[saw-jan]

@nirajacharya2 @S-Panta
Which endpoint you are using for the test? drives.permissions or drives.root?

[nirajacharya2]

@nirajacharya2 @S-Panta Which endpoint you are using for the test? drives.permissions or drives.root?

permissions

[saw-jan]

I would recommend to cover the cases for root endpoint first and then same with permissions endpoint.
Because web client uses root for drive sharing

[nirajacharya2]

i think those coverage for root endpoint are done

• removing : [tests-only][full-ci]add tests for removing share link #9123
• updating : [tests-only][full-ci]Add tests for update shares using root endpoint #8906

[saw-jan]

Waiting for cs3org/reva#4633