Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ocis] All Space Members should be able to create internal links #8960

Closed
13 tasks
tbsbdr opened this issue Apr 25, 2024 · 13 comments
Closed
13 tasks

[ocis] All Space Members should be able to create internal links #8960

tbsbdr opened this issue Apr 25, 2024 · 13 comments
Assignees
Labels
Type:Story User Story

Comments

@tbsbdr
Copy link

tbsbdr commented Apr 25, 2024

Description

User Stories

  • As a Space member I want to create internal links some link so that I can send a "pointer" to my colleagues who are already member of that space/share.

Value

  • collaboration

Acceptance Criteria

  • Any Space Member (Viewer, Editor ...) should be able to create internal links

Definition of ready

  • Everybody needs to understand the value written in the user story
  • Acceptance criteria have to be defined
  • All dependencies of the user story need to be identified
  • Feature should be seen from an end user perspective
  • Story has to be estimated
  • Story points need to be less than 20

Definition of done

  • Functional requirements
    • Functionality described in the user story works
    • Acceptance criteria are fulfilled
  • Quality
    • Code review happened
    • CI is green (that includes new and existing automated tests)
    • Critical code received unit tests by the developer
  • Non-functional requirements
    • No sonar cloud issues
  • Configuration changes
    • The next branch of the ocis charts is compatible
@tbsbdr tbsbdr added the Type:Story User Story label Apr 25, 2024
@tbsbdr
Copy link
Author

tbsbdr commented Apr 25, 2024

@micbar tbh I wonder why it is they way it is currently. is this actually a bug?

@micbar
Copy link
Contributor

micbar commented Apr 26, 2024

This currently works as designed.
Links are bound to the "can share permission". If we grant that to the users, everybody can share.

@tbsbdr
Copy link
Author

tbsbdr commented Apr 26, 2024

hm, yes.. anything we can provide like we had for the private link would be good.

rephrased the userstory:

  • As a Space member I want to create internal links some link so that I can send a "pointer" to my colleagues who are already member of that space/share.

@ScharfViktor
Copy link
Contributor

Space member can send the url of the space, like: https://host.docker.internal:9200/files/spaces/project/s1
if another space member has access -> space should be open

@kobergj
Copy link
Collaborator

kobergj commented May 2, 2024

This currently works as designed.

I'm not entirely sure that is correct. At least the code is aware that private links do not require some permissions. https://github.com/cs3org/reva/blob/edge/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go#L71

Maybe the fact that it still checks for the ocs share permission in that case is just a bug?

@kobergj
Copy link
Collaborator

kobergj commented May 2, 2024

I'm not entirely sure that is correct. At least the code is aware that private links do not require some permissions. https://github.com/cs3org/reva/blob/edge/internal/http/services/owncloud/ocs/handlers/apps/sharing/shares/public.go#L71

Maybe the fact that it still checks for the ocs share permission in that case is just a bug?

Actually, I'm pretty sure this is a bug. The code states it here: https://github.com/cs3org/reva/blob/edge/internal/grpc/services/publicshareprovider/publicshareprovider.go#L219

@micbar
Copy link
Contributor

micbar commented May 2, 2024

@kobergj

"All users should create internal links" That comment is true as far as the user permissions are involved.

But on the resource, they also need the AddGrant permission. In their own personal spaces, they have that permission. But not in project spaces.

@kobergj
Copy link
Collaborator

kobergj commented May 2, 2024

But on the resource, they also need the AddGrant permission. In their own personal spaces, they have that permission. But not in project spaces.

Yes I know. But looking at the code making exceptions for internal links I would rather consider this a bug.

But I'm not fighting over this. If you say this a feature - it is a feature 👍

@micbar
Copy link
Contributor

micbar commented May 2, 2024

Chat in person with @kobergj

Solution: We will adapt the logic.

@micbar
Copy link
Contributor

micbar commented Jun 19, 2024

Fix in progress cs3org/reva@4ec7ca5

@micbar micbar moved this from Qualification to In progress in Infinite Scale Team Board Jun 19, 2024
@micbar micbar self-assigned this Jun 19, 2024
@micbar micbar moved this from In progress to Backlog in Infinite Scale Team Board Jul 8, 2024
@micbar micbar changed the title All Space Members should be able to create internal links [ocis] All Space Members should be able to create internal links Jul 8, 2024
@micbar micbar moved this from Backlog to In progress in Infinite Scale Team Board Jul 8, 2024
@micbar
Copy link
Contributor

micbar commented Jul 8, 2024

Rebased my reva PR

@micbar
Copy link
Contributor

micbar commented Jul 9, 2024

@dragonchaser @fschade @rhafer review is now possible.

@micbar micbar moved this from In progress to Backlog in Infinite Scale Team Board Jul 29, 2024
@micbar
Copy link
Contributor

micbar commented Jul 29, 2024

Brought in via #9708

@micbar micbar closed this as completed Jul 29, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Infinite Scale Team Board Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type:Story User Story
Projects
Status: Done
Development

No branches or pull requests

4 participants