-
Notifications
You must be signed in to change notification settings - Fork 196
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests-only][full-ci] adding test for listing permission of personal drive by a diffrent user #8932
Conversation
17ad5ee
to
9d766ed
Compare
@nirajacharya2 You have conflicts, please, rebase the PR |
9518848
to
497c16f
Compare
497c16f
to
46b4366
Compare
Given using spaces DAV path | ||
And user "Brian" has been created with default attributes and without skeleton files | ||
When user "Brian" tries to list the permissions of space "Personal" owned by "Alice" using permissions endpoint of the Graph API | ||
Then the HTTP status code should be "404" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should not it be a 403 status code? user accessing the another owned resource? just a guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IMO, 404
is good here. because no user with any role should not be able to stat/access other user's personal space
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, for this sort of access attempt 404
needs to be returned whenever the request tries to access a resource that it does not have permission to access.
Otherwise, if it did return 403
for a resource that exists but the user has no permission, and 404
for a resource that does not exist at all, then the user could try to guess lots of "random" resources, and would know that the ones that return 403
do actually exist. That would reveal something that the user should not be able to know (the guessed name of the resource...)
46b4366
to
fdb7de8
Compare
fc97226
to
1909682
Compare
…h viewer permission (#8910)
1909682
to
dff5d73
Compare
|
Description
this pr adds test for listing permission of personal space by a different user
added scenarios
Related Issue
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: