Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[tests-only][full-ci] adding test for listing permission of a project drive by a member with viewer permission #8910

Merged
merged 1 commit into from
Apr 25, 2024
Merged

[tests-only][full-ci] adding test for listing permission of a project drive by a member with viewer permission #8910

merged 1 commit into from
Apr 25, 2024

Conversation

nirajacharya2
Copy link
Contributor

Description

this pr adds test for listing permissions of a project drive by a member with viewer permission

added scenarios

Scenario: member of a project drive with viewer permission lists the permissions of the drive

Related Issue

Motivation and Context

How Has This Been Tested?

  • test environment:
  • locally
  • ci

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Technical debt
  • Tests only (no source changes)

Checklist:

  • Code changes
  • Unit tests added
  • Acceptance tests added
  • Documentation ticket raised:

@nirajacharya2 nirajacharya2 self-assigned this Apr 22, 2024
@nirajacharya2 nirajacharya2 mentioned this pull request Apr 22, 2024
Closed
18 tasks
@nirajacharya2 nirajacharya2 marked this pull request as ready for review April 23, 2024 06:37
PrajwolAmatya
PrajwolAmatya reviewed Apr 24, 2024
View reviewed changes
Copy link
Contributor

@PrajwolAmatya PrajwolAmatya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nirajacharya2 nirajacharya2 force-pushed the list-perm-project-viewer branch from 54f5981 to f2826f2 Compare April 24, 2024 08:41
@nirajacharya2 nirajacharya2 requested a review from saw-jan April 24, 2024 08:41
@nirajacharya2 nirajacharya2 force-pushed the list-perm-project-viewer branch 2 times, most recently from e73e55a to e4b4b50 Compare April 24, 2024 10:46
@nirajacharya2 nirajacharya2 force-pushed the list-perm-project-viewer branch from e4b4b50 to 5464e49 Compare April 25, 2024 03:31
@nirajacharya2 nirajacharya2 requested a review from saw-jan April 25, 2024 03:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@saw-jan saw-jan merged commit baaf630 into master Apr 25, 2024
4 checks passed
@delete-merged-branch delete-merged-branch bot deleted the list-perm-project-viewer branch April 25, 2024 06:41
ownclouders pushed a commit that referenced this pull request Apr 25, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
b11d510 
…h viewer permission (#8910)
nirajacharya2 added a commit that referenced this pull request Apr 25, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
9d766ed 
…h viewer permission (#8910)
nirajacharya2 added a commit that referenced this pull request Apr 25, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
9518848 
…h viewer permission (#8910)
nirajacharya2 added a commit that referenced this pull request Apr 25, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
497c16f 
…h viewer permission (#8910)
nirajacharya2 added a commit that referenced this pull request Apr 25, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
46b4366 
…h viewer permission (#8910)
nirajacharya2 added a commit that referenced this pull request Apr 30, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
fdb7de8 
…h viewer permission (#8910)
nirajacharya2 added a commit that referenced this pull request Apr 30, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
fc97226 
…h viewer permission (#8910)
nirajacharya2 added a commit that referenced this pull request Apr 30, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
1909682 
…h viewer permission (#8910)
nirajacharya2 added a commit that referenced this pull request Apr 30, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
dff5d73 
…h viewer permission (#8910)
saw-jan pushed a commit that referenced this pull request Apr 30, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
34b13f9 
…h viewer permission (#8910) (#8932)
ownclouders pushed a commit that referenced this pull request Apr 30, 2024
@nirajacharya2
adding test for listing permission of a project drive by a member wit…
ab33a2b 
…h viewer permission (#8910) (#8932)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grgprarup grgprarup Awaiting requested review from grgprarup

@SagarGi SagarGi Awaiting requested review from SagarGi

@amrita-shrestha amrita-shrestha Awaiting requested review from amrita-shrestha

@nabim777 nabim777 Awaiting requested review from nabim777

@S-Panta S-Panta Awaiting requested review from S-Panta

@PrajwolAmatya PrajwolAmatya Awaiting requested review from PrajwolAmatya

@saw-jan saw-jan Awaiting requested review from saw-jan

Assignees

@nirajacharya2 nirajacharya2

Labels
QA:team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nirajacharya2 @saw-jan @PrajwolAmatya