-
Notifications
You must be signed in to change notification settings - Fork 187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Default Space Images #8558
Default Space Images #8558
Conversation
Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes. |
05db398
to
ec8c11f
Compare
Thank you!! |
The Space Icon in Web is: https://remixicon.com/icon/function-fill |
ec8c11f
to
9d4700c
Compare
42d6954
to
4d58914
Compare
Signed-off-by: jkoberg <[email protected]>
Signed-off-by: jkoberg <[email protected]>
4d58914
to
a0e2648
Compare
Rebased to master because of merge conflicts - no code changes |
Quality Gate passedIssues Measures |
@@ -0,0 +1 @@ | |||
Here you can add a description for this Space. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Web was putting a translated text, based on the language of the user. Can you translate the text backend side as well? Accept-language
header should be available on the POST
request that creates the space.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would be a hard requirement to enable this feature 🙋♀️
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Collecting issues with space templates here: #8713
Moves space creation logic (
.space
folder, initialreadme.md
, default image) to server instead relying on client logic.Needs cs3org/reva#4545Needs web changes (less requests)Adds a new parameter "template" to the create drive request. Setting this to "default" will auto generate
.space
folder,readme.md
and a space image.The CS3 metadata client using service accounts talks directly to the storage providers.
Can be extended later to support custom space templates.