Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default Space Images #8558

Merged
merged 2 commits into from
Mar 7, 2024
Merged

Conversation

kobergj
Copy link
Collaborator

@kobergj kobergj commented Mar 1, 2024

Moves space creation logic (.space folder, initial readme.md, default image) to server instead relying on client logic.

Needs cs3org/reva#4545
Needs web changes (less requests)

Adds a new parameter "template" to the create drive request. Setting this to "default" will auto generate .space folder, readme.md and a space image.

The CS3 metadata client using service accounts talks directly to the storage providers.

Can be extended later to support custom space templates.

Copy link

update-docs bot commented Mar 1, 2024

Thanks for opening this pull request! The maintainers of this repository would appreciate it if you would create a changelog item based on your changes.

@kobergj kobergj force-pushed the ServerSideSpaceDefaults branch 7 times, most recently from 05db398 to ec8c11f Compare March 5, 2024 14:32
@TheOneRing
Copy link
Contributor

Thank you!!

@tbsbdr
Copy link

tbsbdr commented Mar 5, 2024

The Space Icon in Web is: https://remixicon.com/icon/function-fill

@kobergj kobergj force-pushed the ServerSideSpaceDefaults branch from ec8c11f to 9d4700c Compare March 6, 2024 09:06
@kobergj kobergj marked this pull request as ready for review March 6, 2024 09:11
@kobergj kobergj force-pushed the ServerSideSpaceDefaults branch 2 times, most recently from 42d6954 to 4d58914 Compare March 6, 2024 14:45
@kobergj kobergj force-pushed the ServerSideSpaceDefaults branch from 4d58914 to a0e2648 Compare March 7, 2024 12:01
@kobergj
Copy link
Collaborator Author

kobergj commented Mar 7, 2024

Rebased to master because of merge conflicts - no code changes

Copy link

sonarqubecloud bot commented Mar 7, 2024

@kobergj kobergj merged commit dadd7cc into owncloud:master Mar 7, 2024
3 checks passed
@kobergj kobergj deleted the ServerSideSpaceDefaults branch March 7, 2024 12:40
ownclouders pushed a commit that referenced this pull request Mar 7, 2024
ownclouders pushed a commit that referenced this pull request Mar 8, 2024
@@ -0,0 +1 @@
Here you can add a description for this Space.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Web was putting a translated text, based on the language of the user. Can you translate the text backend side as well? Accept-language header should be available on the POST request that creates the space.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would be a hard requirement to enable this feature 🙋‍♀️

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Collecting issues with space templates here: #8713

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants